Skip to content

Fix convert_to_dapr_duration double-counting sub-second time #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amdadulbari wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix convert_to_dapr_duration double-counting sub-second time #1192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8cc226d
Fix convert_to_dapr_duration double-counting sub-second time
amdadulbari Aug 13, 2026
5a7eef4
Merge branch 'main' into fix/dapr-duration-subsecond
sicoyle Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion dapr/serializers/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,4 +74,7 @@ def convert_to_dapr_duration(td: timedelta) -> str:
milliseconds, microseconds = divmod(td.microseconds, 1000.0)
hours, mins = divmod(total_minutes, 60.0)

return f'{hours:.0f}h{mins:.0f}m{seconds:.0f}s{milliseconds:.0f}ms{microseconds:.0f}μs'
# `seconds` still carries the sub-second fraction, which is also emitted via
# the ms/μs fields below; truncate it so the fraction is not double-counted
# (and so a fraction >= 0.5 is not rounded up into an extra whole second).
return f'{hours:.0f}h{mins:.0f}m{int(seconds)}s{milliseconds:.0f}ms{microseconds:.0f}μs'
7 changes: 7 additions & 0 deletions tests/serializers/test_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,13 @@ def test_convert_timedelta_to_dapr_duration(self):
)
self.assertEqual(duration, '4h15m40s123ms35μs')

def test_convert_timedelta_to_dapr_duration_subsecond(self):
# A sub-second fraction >= 0.5 must not be rounded up into an extra whole
# second nor double-counted with the ms/μs fields; the round-trip must be exact.
duration = convert_to_dapr_duration(timedelta(milliseconds=1500))
self.assertEqual(duration, '0h0m1s500ms0μs')
self.assertEqual(convert_from_dapr_duration(duration), timedelta(milliseconds=1500))

def test_convert_invalid_duration_string(self):
TESTSTRING = '4h15m40s123ms35μshello'
with self.assertRaises(ValueError) as exeception_context:
Expand Down