Repository navigation
fix(parity): allow declared product changes through FR-014 guard - #704
Merged
Merged
Conversation
Preserve the parity scope guard while allowing product PRs to declare required harness compatibility updates using a Git commit trailer. Assisted-by: Cursor:Claude-Opus-5.5 Signed-off-by: Johnson Lyu <cl7084@nyu.edu>
Marc-cn
approved these changes
Nov 4, 2026
Marc-cn
left a comment
Collaborator
There was a problem hiding this comment.
Checked on the VM against main: 11 passed, the guard skips on this PR as the existing rule says (only the guard file changed), ruff clean. The escape is explicit, visible to the reviewer, read by git's own trailer parser so prose can't trigger it, and the default stays fail-closed; the tests cover the cases that matter (invalid value, mention in prose, later commit). Fine as the fix for the #620 false positive. One nit, not blocking: nothing outside this test file says the trailer exists, so the next person who hits the guard won't find it — a sentence in the FR-014 assertion message ('or declare a product PR with the trailer Parity-Guard: not-a-parity-pr') or in CONTRIBUTING would do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parity-Guard: not-a-parity-prcommit trailer.Type of Change
Framework Changes Checklist
If this PR modifies the darnit framework (
packages/darnit/):docs/architecture/framework-design.md) if behavior changeduv run python scripts/validate_sync.py --verboseand it passesNo framework source changes.
Control/TOML Changes Checklist
If this PR modifies controls or TOML configuration:
Not applicable; no control or TOML changes.
Testing
uv run pytest tests/ -v)uv run ruff check .)Additional validation:
git diff --checkpassed.AI assistance
Cursor (Claude Opus 5.5) assisted with implementation, refactoring, and regression tests. Changes were reviewed and validated locally.
Additional Notes
This is a standalone fix for the FR-014 false positive identified during review of #620.
The trailer is an explicit, reviewer-visible declaration, not proof of compatibility. Reviewers must verify that the parity-harness changes are necessary for the product change. Without the declaration, the existing guard remains enforced.
Only
tests/darnit/parity/tier1/test_no_product_changes.pyis modified.