Skip to content

remove unnecessary string intern #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sergeevik wants to merge 1 commit into
base: main
Choose a base branch
from
Open

remove unnecessary string intern #136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/main/java/com/dashjoin/jsonata/Functions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ static public String substr(String str, Integer start, Integer length) {
// below has to convert start and length for emojis and unicode
int origLen = str.length();

String strData = Objects.requireNonNull(str).intern();
String strData = Objects.requireNonNull(str);
int strLen = strData.codePointCount(0, strData.length());
if (start >= strLen) {
return "";
Expand Down Expand Up @@ -608,10 +608,10 @@ public static String leftPad(final String str, final int size, String padStr) {
padStr = " ";
}

String strData = Objects.requireNonNull(str).intern();
String strData = Objects.requireNonNull(str);
int strLen = strData.codePointCount(0, strData.length());

String padData = Objects.requireNonNull(padStr).intern();
String padData = Objects.requireNonNull(padStr);
int padLen = padData.codePointCount(0, padData.length());

if (padLen == 0) {
Expand All @@ -637,10 +637,10 @@ public static String rightPad(final String str, final int size, String padStr) {
padStr = " ";
}

String strData = Objects.requireNonNull(str).intern();
String strData = Objects.requireNonNull(str);
int strLen = strData.codePointCount(0, strData.length());

String padData = Objects.requireNonNull(padStr).intern();
String padData = Objects.requireNonNull(padStr);
int padLen = padData.codePointCount(0, padData.length());

if (padLen == 0) {
Expand Down
Loading