[sergeevik]

In js array may be object with key as index
some another fix:

• remove generic in string method. replace with toString
• applyInner check not null before use in matcher
• check ? when arg type is operator by toString.equals (? is char in value)
• 2 test for each partial expression

[sergeevik]

maybe better:

var lhsNewMap =  new HashMap();
var lhsOldList = (List)lhs;
for (int i = 0; i < lhsOldList.size(); i++) {
  lhsNewMap.put(i, tempLhs.get(i));
}
lhs = lhsNewMap;

[uw4]

Thanks + good catch!
We're reviewing this behavior of $each with list as input -
we want to clarify this with the original Jsonata maintainers, might be as well be a glitch in the original impl

[sergeevik]

find some another bug caused by this fix.
fix realisation wrapped all partial expression. but need only to each (caught bug with $map function)

@uw4 @aeberhart any updates about for this bug?

memory pill for me:

json:

{
  "buildings": {
    "home": {
      "address": "home address",
      "period": "11 month on 12",
      "presentation": {
        "first": {
          "widget": {
            "data": "home widget"
          }
        }
      }
    },
    "work": {
      "address": "work address",
      "presentation": {
        "first": {
          "widget": {
            "data": "work widget"
          }
        }
      }
    },
    "vacancy": {
      "address": "vacancy address",
      "period": "1 month on 12",
      "presentation": {
        "first": {
          "widget": {
            "data": "vacancy widget"
          }
        }
      }
    },
    "old": {
      "address": "old address",
      "period": "2 month on 12",
      "presentation": {
        "first": {
          "widget": {
            "data": "old widget"
          }
        }
      }
    },
    "operation": {
      "address": "operation address",
      "period": "3 month on 12",
      "presentation": {
        "first": {
          "widget": {
            "data": "operation widget"
          }
        }
      }
    }
  }
}

and expression

$sift($.buildings, function($v, $k) { $k ~> /o/ and $v.presentation.*.widget})
                    ~> $each(?, function($v, $key) {{ $key: $sift($v.presentation, function($v, $k){ $v.widget }) }})
                    ~> $map(?, function($v){($v.*)})

not fork after this fix and not coverage by tests

[sergeevik]

I've fix the example-bug above. It's not the best solution, but I haven't come up with anything else yet. I've also added a test from my post with verification.

[aeberhart]

Thanks a lot @sergeevik for reporting #79 and for this PR! The issue is now fixed on main, following the jsonata-js approach discussed in #79: partially applied native functions no longer re-validate their signature (#132), and $each / $merge iterate arrays like JS for..in (#131). Your test cases, including the map_in_pipe example, were added to OldPrsTest. Closing this one as superseded.