acc: remove the bundle directories left behind after cloud test runs - #6350
Closed
shreyas-goenka wants to merge 2 commits into
Closed
acc: remove the bundle directories left behind after cloud test runs#6350shreyas-goenka wants to merge 2 commits into
shreyas-goenka wants to merge 2 commits into
Conversation
The suite-level cleanup added in #6092 destroys every deployment this run leaked, but `bundle destroy` only removes the deployment root under ~/.bundle/<name> and never the <name> directory itself. Every run picks a fresh bundle name, so nothing reuses those directories and they pile up against the workspace child-node limit -- the CLI test workspace reached 48k+ nodes that way and had to be allow-listed to 100k (ES-2138924). Remove them in the same sweep, right after the destroys. The delete is recursive, so a directory a killed test left half-written goes too, even when no deployment root was found under it. A directory whose destroy failed is kept, so its state is still available to the periodic sweep that reclaims it. Co-authored-by: Isaac
Collaborator
Integration test reportCommit: 15ab7cb
Top 6 slowest tests (at least 2 minutes):
|
Co-authored-by: Isaac
shreyas-goenka
marked this pull request as ready for review
August 24, 2026 06:21
Contributor
Waiting for approvalBased on git history, these people are best suited to review:
Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
Contributor
Author
|
Closing: we decided to solve this in the application instead — #6317 makes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The suite cleanup from #6092 destroys each leaked deployment but leaves the
~/.bundle/<name>directory above it, and bundle names are never reused, so they pile up — that is what exhausted the test workspace (ES-2138924). Remove them in the same sweep. A directory whose destroy failed is left alone so the periodic sweep can still use its state.This pull request and its description were written by Isaac.