Repository navigation
acc: Avoid selecting entire invariant suites when adding exclusions - #7307
Merged
Merged
Conversation
Collaborator
Integration test reportCommit: ce1ff05
Top 25 slowest tests (at least 2 minutes):
|
denik
approved these changes
Nov 3, 2026
denik
left a comment
denik
left a comment
Contributor
There was a problem hiding this comment.
Not clear what this does. We have acceptance test
acceptance/selftest/selection
maybe add similar one that demoes this feature?
janniklasrose
changed the title
Contributor
|
Commit: Regression test reportSelected 1 changed tests (limit=20, 0 not selected) 1 tests: regression=0 unreleased=0 coverage=1 failing=0
|
Collaborator
Integration test reportCommit: 7adc80d
40 interesting tests: 34 FAIL, 6 flaky
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Stop selecting an entire invariant suite when its
test.tomlonly adds exclusions. Script changes, removed exclusions, and overrides of inherited rules still select the suite.The new Git-backed
acceptance/selftest/selection_exclusionshas two suites,migrateandno_drift. Addingnew.yml.tmpland excluding it frommigrateselects onlyno_drift/INPUT_CONFIG=new.yml.tmpl. Changing the migration script or removing its exclusion selects the migration suite again.The harness also omits unselected variants from the report and explicitly skips a directory if no selected variants remain after exclusions.
Why
The report on #7094 had 660 rows for 14 selected entries: 551 filtered-out variants and 84 unrelated migration cases. Those rows filled the comment budget and hid all 16 failure details.
limit=20caps selection entries; one directory entry can expand to many matrix variants.Tests
./task fmt,./task checks, and./task lintpass../task testpasses. Both variants of the existingpresets_name_prefix_devtest passed on retry after a temporary sandbox/tmp/.gitartifact caused Git metadata mismatches.Replayed
acceptance/selftest/selection_exclusions/scriptagainst the pre-fix selector (050b89d) and this PR. For the first scenario, adding a template and excluding it from migration:Before the fix:
With this PR:
The extra
migrateentry selected all existing migration variants even though the config edit only added an exclusion. The other two scenarios print identically before and after: changing the migration script or removing the exclusion still selects migration.This PR and its description were written by Codex.