Repository navigation
acc: update postgres update_mask=spec factcheck for new backend behavior - #7308
Merged
Merged
Conversation
Since 2026-11-02 the postgres API no longer returns 500 for update_mask=spec with a body that omits non-default default_endpoint_settings; it keeps the stored settings. Drop the 500 emulation from the testserver and update the golden. Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Commit: Regression test reportSelected 1 changed tests (limit=20, 0 not selected) 1 tests: regression=0 unreleased=0 coverage=1 failing=0
|
denik
marked this pull request as ready for review
November 3, 2026 12:23
denik
enabled auto-merge
November 3, 2026 12:25
Collaborator
Integration test reportCommit: f4bdbc6
Top 6 slowest tests (at least 2 minutes):
|
pietern
approved these changes
Nov 3, 2026
Collaborator
Integration test reportCommit: aae07ca
75 interesting tests: 32 MISS, 23 flaky, 20 FAIL
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Since 2026-11-02 ~16:00 UTC the postgres API no longer returns 500 for
update-project ... specwhen the body omits a non-defaultdefault_endpoint_settings. It now applies the request and keeps the stored settings (patch semantics). This PR:wholeSpecMasked,isNonDefaultEndpointSettings,nextTraceID, all now unused),factcheck/update_mask_specgolden and script comment,[TRACE_ID]replacement, which only that error used.Why
factcheck/update_mask_spechas failed on every AWS cloud run since then: 28 failures across Linux and Windows.Dashboard:
Tests
go test ./acceptance -run TestAccept/bundle/resources/postgres -updatechanges only this golden.factcheck/update_mask_specandfactcheck/update_mask_starpass.This pull request and its description were written by Isaac.