Repository navigation
[SSH] Make --environment-version flag public - #7310
Merged
Merged
Conversation
Serverless environment versions 5 and 6 now work with the tunnel in the regions where the driver's sandbox port forwarding is enabled, so users need a supported way to opt in before the default moves off 4. Make the flag visible, and close the two gaps a public flag would expose: - Fold an explicit version into the default connection name, the same way --base-environment already is. Otherwise `ssh connect` followed by `ssh connect --environment-version 5` reuses the running version 4 server. - Reject the flag together with --cluster instead of silently ignoring it, matching --base-environment and --usage-policy-id. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
rclarey
requested review from
anton-107,
lennartkats-db and
louis-johnston-db
and removed request for
louis-johnston-db
November 3, 2026 12:27
rclarey
changed the title
anton-107
reviewed
Nov 3, 2026
Collaborator
Integration test reportCommit: 6486b06
Top 10 slowest tests (at least 2 minutes):
|
anton-107
approved these changes
Nov 3, 2026
anton-107
left a comment
anton-107
left a comment
Contributor
There was a problem hiding this comment.
The changelog now covers the default-name change and the cleanup of the old secret scope and local files. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
ssh connect --environment-versionnow shows in help, with a description that is no longer AI-Runtime-only, and with an example.--base-environmentalready is. So twossh connectcommands with different environment versions start two different servers.--cluster, matching--base-environmentand--usage-policy-id.Why
CPU serverless environments 5 and 6 now work with the tunnel wherever the REPL sandbox's port forwarding is enabled. Users need a supported opt-in before the default moves off 4 once the rollout finishes. The IDE path already picks up the flag:
ssh connect --ide vscode --environment-version 5carries it in the generated ProxyCommand.ssh setupis dedicated-only, so it gets no flag.Before this change the flag was hidden and ignored with
--cluster, so rejecting that pair can only affect a hand-written invocation that never had any effect.Tests
go test ./acceptance -run TestAccept/sshpasses.--helpoutput and the--clusterrejection.