Repository navigation
Read the Go SDK's _last_sha in the SDK consistency check - #7317
Merged
Merged
Conversation
The Go SDK records the spec commit each release was generated from in .codegen/_last_sha. Its .codegen/_openapi_sha is now a copy of that value kept for older tooling and is being phased out. TestConsistentDatabricksSdkVersion and the bump-sdk skill now read _last_sha. Both files hold the same value at every SDK release since v0.188.0, including the v0.193.0 pin on main. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: e69be5b
Top 22 slowest tests (at least 2 minutes):
|
Divyansh-db
enabled auto-merge
November 3, 2026 16:56
hectorcast-db
approved these changes
Nov 4, 2026
andrewnester
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
TestConsistentDatabricksSdkVersionand the bump-sdk skill now read the Go SDK's.codegen/_last_shaat the pinned version instead of.codegen/_openapi_sha. The CLI's own.codegen/_openapi_shais unchanged.Why
The Go SDK records the spec commit each release was generated from in
_last_sha. Its_openapi_shais now a copy of that value kept for older tooling and is being phased out. The two files hold the same value at every SDK release since v0.188.0, including the v0.193.0 pin onmain, so the check's result doesn't change.Tests
go test -run TestConsistentDatabricksSdkVersion ./internal/buildpasses on this branch: the CLI's.codegen/_openapi_shamatches the SDK's_last_shaat v0.193.0.This pull request and its description were written by Isaac.