Repository navigation
[SSH] Support IDE path override for SSH - #7322
Merged
Merged
Conversation
rclarey
changed the title
Collaborator
Integration test reportCommit: a286464
Top 6 slowest tests (at least 2 minutes):
|
rclarey
marked this pull request as ready for review
November 4, 2026 08:14
rclarey
requested review from
abdelrahmanomar1515,
andrewnester and
maksim-zuev-db
November 4, 2026 08:14
louis-johnston-db
approved these changes
Nov 4, 2026
louis-johnston-db
left a comment
louis-johnston-db
left a comment
There was a problem hiding this comment.
lgtm, with just a reminder to add "IDE_COMMAND_OVERRIDE_INVALID" to SshTunnelErrorCategory.Type in the databricks_cli proto.
Contributor
Author
|
Already done 👍 |
rclarey
enabled auto-merge
November 4, 2026 08:46
maksim-zuev-db
approved these changes
Nov 4, 2026
| return consentErrorf(ErrSSHExtensionInstallUnavailable, | ||
| "%s Install it with: %s --install-extension %s, or pass --auto-approve", | ||
| msg, ide.Command, ide.SSHExtensionID) | ||
| msg, command, ide.SSHExtensionID) |
Member
There was a problem hiding this comment.
command may contain spaces now, should we quote it?
e.g. /Applications/Visual Studio Code.app/...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Support
DATABRICKS_SSH_IDE_COMMANDfor overriding the IDE executable used fordatabricks ssh connect --ide XWhy
Sometimes VSCode / Cursor are installed without putting their respective executables on
PATHwhich causes an error when trying to open an SSH connection. Since the VSCode extension can read the installation directory we can instead derive the executable path and pass it to the CLI to prevent thePATHlookup and resolve the previous errorsTests