Skip to content

Quote resource keys in bundle config sync paths - #7328

Merged
ilyakuz-db merged 3 commits into
mainfrom
ilyakuz-db/fix-config-sync-resource-keys
Nov 4, 2026
Merged

Quote resource keys in bundle config sync paths#7328
ilyakuz-db merged 3 commits into
mainfrom
ilyakuz-db/fix-config-sync-resource-keys

Conversation

@ilyakuz-db

@ilyakuz-db ilyakuz-db commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Changes

Quote resource names when constructing config-sync field paths, keeping spaces, dots, and quotes within one key. Use structured paths for variable-reference lookups so edits and new sequence elements preserve their references.

Why

bundle config-remote-sync fails for resource keys such as daily job because it passes an unquoted path to the path parser. Quoting the resource key lets sync locate and update the intended YAML entry.

Tests

  • All 93 local config-sync acceptance cases passed, including new coverage for spaced and quoted resource keys, resource-ID selection, field edits, task additions, and variable preservation.
  • Extended the task rename/revert acceptance test to use spaces and both quote types; both acceptance regressions fail against the unchanged CLI with the original path-parser error.
  • All 83 config-sync package test cases passed, including the extended dotted-resource-key YAML rewrite test.
  • go vet ./bundle/configsync, formatting, shell syntax, and whitespace checks passed.

Local Go validation used a temporary YAML v3.0.5 override because the pinned v3.0.6 dependency was unavailable in the test environment. Dependency files are unchanged.

Dotted resource names are covered at the YAML rewrite layer; the separate existing deployment failure for dotted keys is outside this change.

This PR was created with GitHub MCP.

@github-actions github-actions Bot added the DABs DABs related issues label Nov 3, 2026
@ilyakuz-db
ilyakuz-db marked this pull request as ready for review November 3, 2026 16:00
@ilyakuz-db
ilyakuz-db requested review from a team as code owners November 3, 2026 16:00
@github-actions

github-actions Bot commented Nov 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Commit: 14b9e6818 | Workflow run

Regression test report

Selected 2 changed tests (limit=20, 0 not selected)

4 tests: regression=4 unreleased=0 coverage=0 failing=0
test branch main (5bda5d4) latest (v1.23.0)
TestAccept/bundle/config-remote-sync/resource_keys/DMS= ✅ ❌ ❌
TestAccept/bundle/config-remote-sync/resource_keys/DMS=true ✅ ❌ ❌
TestAccept/bundle/config-remote-sync/task_rename_revert/DMS= ✅ ❌ ❌
TestAccept/bundle/config-remote-sync/task_rename_revert/DMS=true ✅ ❌ ❌
TestAccept/bundle/config-remote-sync/resource_keys/DMS=: branch ✅ | main (5bda5d4) ❌ | latest (v1.23.0) ❌

main (5bda5d4):

acceptance_test.go:1342: Diff:
        --- bundle/config-remote-sync/resource_keys/output.txt
        +++ /tmp/TestAcceptbundleconfig-remote-syncresource_keysDMS=2435086854/002/output.txt
        @@ -4,107 +4,8 @@
         === Edit job with spaces remotely
         === Sync only job with spaces
         >>> [CLI] bundle config-remote-sync --select-ids jobs:[JOB WITH SPACES_ID] --save
        -Detected changes in 1 resource(s):
        +Error: failed to resolve field changes: failed to resolve selectors in path resources.jobs.job with spaces.tasks[task_key='main'].notebook_task.notebook_path: failed to parse path resources.jobs.job with spaces.tasks[task_key='main'].notebook_task.notebook_path: invalid character ' ' in field name at position 18
         
        -Resource: resources.jobs.job with spaces
        -  description: add
        -  tasks[task_key='main'].notebook_task.notebook_path: replace
        -  tasks[task_key='main'].timeout_seconds: replace
        -
        -
        -
        ->>> diff.py databricks.yml.backup databricks.yml
        ---- databricks.yml.backup
        -+++ databricks.yml
        -@@ -12,7 +12,8 @@
        -       tasks:
        -         - task_key: main
        --          timeout_seconds: 60
        -+          timeout_seconds: 900
        -           notebook_task:
        --            notebook_path: ${var.notebook_root}/notebook
        -+            notebook_path: ${var.notebook_root}/notebook_updated
        -+      description: Remote description
        -     "job's\"quotes":
        -       name: quoted-job
        -
        -=== Syncing job with spaces again is idempotent
        ->>> [CLI] bundle config-remote-sync --select-ids jobs:[JOB WITH SPACES_ID] --save
        -No changes detected.
        -
        -
        -=== Add a sibling task in job with spaces
        ->>> [CLI] bundle config-remote-sync --select-ids jobs:[JOB WITH SPACES_ID] --save
        -Detected changes in 1 resource(s):
        -
        -Resource: resources.jobs.job with spaces
        -  tasks[task_key='added']: add
        -
        -
        -
        ->>> diff.py databricks.yml.backup databricks.yml
        ---- databricks.yml.backup
        -+++ databricks.yml
        -@@ -15,4 +15,7 @@
        -           notebook_task:
        -             notebook_path: ${var.notebook_root}/notebook_updated
        -+        - notebook_task:
        -+            notebook_path: ${var.notebook_root}/notebook_updated_sibling
        -+          task_key: added
        -       description: Remote description
        -     "job's\"quotes":
        -
        -=== Edit job's"quotes remotely
        -=== Sync only job's"quotes
        ->>> [CLI] bundle config-remote-sync --select-ids jobs:[JOB'S\"QUOTES_ID] --save
        -Detected changes in 1 resource(s):
        -
        -Resource: resources.jobs.job's"quotes
        -  description: add
        -  tasks[task_key='main'].notebook_task.notebook_path: replace
        -  tasks[task_key='main'].timeout_seconds: replace
        -
        -
        -
        ->>> diff.py databricks.yml.backup databricks.yml
        ---- databricks.yml.backup
        -+++ databricks.yml
        -@@ -23,7 +23,8 @@
        -       tasks:
        -         - task_key: main
        --          timeout_seconds: 60
        -+          timeout_seconds: 900
        -           notebook_task:
        --            notebook_path: ${var.notebook_root}/notebook
        -+            notebook_path: ${var.notebook_root}/notebook_updated
        -+      description: Remote description
        -
        - targets:
        -
        -=== Syncing job's"quotes again is idempotent
        ->>> [CLI] bundle config-remote-sync --select-ids jobs:[JOB'S\"QUOTES_ID] --save
        -No changes detected.
        -
        -
        -=== Add a sibling task in job's"quotes
        ->>> [CLI] bundle config-remote-sync --select-ids jobs:[JOB'S\"QUOTES_ID] --save
        -Detected changes in 1 resource(s):
        -
        -Resource: resources.jobs.job's"quotes
        -  tasks[task_key='added']: add
        -
        -
        -
        ->>> diff.py databricks.yml.backup databricks.yml
        ---- databricks.yml.backup
        -+++ databricks.yml
        -@@ -26,4 +26,7 @@
        -           notebook_task:
        -             notebook_path: ${var.notebook_root}/notebook_updated
        -+        - notebook_task:
        -+            notebook_path: ${var.notebook_root}/notebook_updated_sibling
        -+          task_key: added
        -       description: Remote description
        -
        -
         >>> [CLI] bundle destroy --auto-approve -qq
        +
        +Exit code: 1

latest (v1.23.0): same output as main (5bda5d4)

TestAccept/bundle/config-remote-sync/resource_keys/DMS=true: branch ✅ | main (5bda5d4) ❌ | latest (v1.23.0) ❌

main (5bda5d4):

acceptance_test.go:1342: Diff:
        --- bundle/config-remote-sync/resource_keys/output.txt
        +++ /tmp/TestAcceptbundleconfig-remote-syncresource_keysDMS=true3069004497/002/output.txt
        @@ -4,107 +4,8 @@
         === Edit job with spaces remotely
         === Sync only job with spaces
         >>> [CLI] bundle config-remote-sync --select-ids jobs:[JOB WITH SPACES_ID] --save
        -Detected changes in 1 resource(s):
        +Error: failed to resolve field changes: failed to resolve selectors in path resources.jobs.job with spaces.tasks[task_key='main'].notebook_task.notebook_path: failed to parse path resources.jobs.job with spaces.tasks[task_key='main'].notebook_task.notebook_path: invalid character ' ' in field name at position 18
         
        -Resource: resources.jobs.job with spaces
        -  description: add
        -  tasks[task_key='main'].notebook_task.notebook_path: replace
        -  tasks[task_key='main'].timeout_seconds: replace
        -
        -
        -
        ->>> diff.py databricks.yml.backup databricks.yml
        ---- databricks.yml.backup
        -+++ databricks.yml
        -@@ -12,7 +12,8 @@
        -       tasks:
        -         - task_key: main
        --          timeout_seconds: 60
        -+          timeout_seconds: 900
        -           notebook_task:
        --            notebook_path: ${var.notebook_root}/notebook
        -+            notebook_path: ${var.notebook_root}/notebook_updated
        -+      description: Remote description
        -     "job's\"quotes":
        -       name: quoted-job
        -
        -=== Syncing job with spaces again is idempotent
        ->>> [CLI] bundle config-remote-sync --select-ids jobs:[JOB WITH SPACES_ID] --save
        -No changes detected.
        -
        -
        -=== Add a sibling task in job with spaces
        ->>> [CLI] bundle config-remote-sync --select-ids jobs:[JOB WITH SPACES_ID] --save
        -Detected changes in 1 resource(s):
        -
        -Resource: resources.jobs.job with spaces
        -  tasks[task_key='added']: add
        -
        -
        -
        ->>> diff.py databricks.yml.backup databricks.yml
        ---- databricks.yml.backup
        -+++ databricks.yml
        -@@ -15,4 +15,7 @@
        -           notebook_task:
        -             notebook_path: ${var.notebook_root}/notebook_updated
        -+        - notebook_task:
        -+            notebook_path: ${var.notebook_root}/notebook_updated_sibling
        -+          task_key: added
        -       description: Remote description
        -     "job's\"quotes":
        -
        -=== Edit job's"quotes remotely
        -=== Sync only job's"quotes
        ->>> [CLI] bundle config-remote-sync --select-ids jobs:[JOB'S\"QUOTES_ID] --save
        -Detected changes in 1 resource(s):
        -
        -Resource: resources.jobs.job's"quotes
        -  description: add
        -  tasks[task_key='main'].notebook_task.notebook_path: replace
        -  tasks[task_key='main'].timeout_seconds: replace
        -
        -
        -
        ->>> diff.py databricks.yml.backup databricks.yml
        ---- databricks.yml.backup
        -+++ databricks.yml
        -@@ -23,7 +23,8 @@
        -       tasks:
        -         - task_key: main
        --          timeout_seconds: 60
        -+          timeout_seconds: 900
        -           notebook_task:
        --            notebook_path: ${var.notebook_root}/notebook
        -+            notebook_path: ${var.notebook_root}/notebook_updated
        -+      description: Remote description
        -
        - targets:
        -
        -=== Syncing job's"quotes again is idempotent
        ->>> [CLI] bundle config-remote-sync --select-ids jobs:[JOB'S\"QUOTES_ID] --save
        -No changes detected.
        -
        -
        -=== Add a sibling task in job's"quotes
        ->>> [CLI] bundle config-remote-sync --select-ids jobs:[JOB'S\"QUOTES_ID] --save
        -Detected changes in 1 resource(s):
        -
        -Resource: resources.jobs.job's"quotes
        -  tasks[task_key='added']: add
        -
        -
        -
        ->>> diff.py databricks.yml.backup databricks.yml
        ---- databricks.yml.backup
        -+++ databricks.yml
        -@@ -26,4 +26,7 @@
        -           notebook_task:
        -             notebook_path: ${var.notebook_root}/notebook_updated
        -+        - notebook_task:
        -+            notebook_path: ${var.notebook_root}/notebook_updated_sibling
        -+          task_key: added
        -       description: Remote description
        -
        -
         >>> [CLI] bundle destroy --auto-approve -qq
        +
        +Exit code: 1
        
FAIL

latest (v1.23.0):

acceptance_test.go:1342: Diff:
        --- bundle/config-remote-sync/resource_keys/output.txt
        +++ /tmp/TestAcceptbundleconfig-remote-syncresource_keysDMS=true2318283822/002/output.txt
        @@ -4,107 +4,8 @@
         === Edit job with spaces remotely
         === Sync only job with spaces
         >>> [CLI] bundle config-remote-sync --select-ids jobs:[JOB WITH SPACES_ID] --save
        -Detected changes in 1 resource(s):
        +Error: failed to resolve field changes: failed to resolve selectors in path resources.jobs.job with spaces.tasks[task_key='main'].notebook_task.notebook_path: failed to parse path resources.jobs.job with spaces.tasks[task_key='main'].notebook_task.notebook_path: invalid character ' ' in field name at position 18
         
        -Resource: resources.jobs.job with spaces
        -  description: add
        -  tasks[task_key='main'].notebook_task.notebook_path: replace
        -  tasks[task_key='main'].timeout_seconds: replace
        -
        -
        -
        ->>> diff.py databricks.yml.backup databricks.yml
        ---- databricks.yml.backup
        -+++ databricks.yml
        -@@ -12,7 +12,8 @@
        -       tasks:
        -         - task_key: main
        --          timeout_seconds: 60
        -+          timeout_seconds: 900
        -           notebook_task:
        --            notebook_path: ${var.notebook_root}/notebook
        -+            notebook_path: ${var.notebook_root}/notebook_updated
        -+      description: Remote description
        -     "job's\"quotes":
        -       name: quoted-job
        -
        -=== Syncing job with spaces again is idempotent
        ->>> [CLI] bundle config-remote-sync --select-ids jobs:[JOB WITH SPACES_ID] --save
        -No changes detected.
        -
        -
        -=== Add a sibling task in job with spaces
        ->>> [CLI] bundle config-remote-sync --select-ids jobs:[JOB WITH SPACES_ID] --save
        -Detected changes in 1 resource(s):
        -
        -Resource: resources.jobs.job with spaces
        -  tasks[task_key='added']: add
        -
        -
        -
        ->>> diff.py databricks.yml.backup databricks.yml
        ---- databricks.yml.backup
        -+++ databricks.yml
        -@@ -15,4 +15,7 @@
        -           notebook_task:
        -             notebook_path: ${var.notebook_root}/notebook_updated
        -+        - notebook_task:
        -+            notebook_path: ${var.notebook_root}/notebook_updated_sibling
        -+          task_key: added
        -       description: Remote description
        -     "job's\"quotes":
        -
        -=== Edit job's"quotes remotely
        -=== Sync only job's"quotes
        ->>> [CLI] bundle config-remote-sync --select-ids jobs:[JOB'S\"QUOTES_ID] --save
        -Detected changes in 1 resource(s):
        -
        -Resource: resources.jobs.job's"quotes
        -  description: add
        -  tasks[task_key='main'].notebook_task.notebook_path: replace
        -  tasks[task_key='main'].timeout_seconds: replace
        -
        -
        -
        ->>> diff.py databricks.yml.backup databricks.yml
        ---- databricks.yml.backup
        -+++ databricks.yml
        -@@ -23,7 +23,8 @@
        -       tasks:
        -         - task_key: main
        --          timeout_seconds: 60
        -+          timeout_seconds: 900
        -           notebook_task:
        --            notebook_path: ${var.notebook_root}/notebook
        -+            notebook_path: ${var.notebook_root}/notebook_updated
        -+      description: Remote description
        -
        - targets:
        -
        -=== Syncing job's"quotes again is idempotent
        ->>> [CLI] bundle config-remote-sync --select-ids jobs:[JOB'S\"QUOTES_ID] --save
        -No changes detected.
        -
        -
        -=== Add a sibling task in job's"quotes
        ->>> [CLI] bundle config-remote-sync --select-ids jobs:[JOB'S\"QUOTES_ID] --save
        -Detected changes in 1 resource(s):
        -
        -Resource: resources.jobs.job's"quotes
        -  tasks[task_key='added']: add
        -
        -
        -
        ->>> diff.py databricks.yml.backup databricks.yml
        ---- databricks.yml.backup
        -+++ databricks.yml
        -@@ -26,4 +26,7 @@
        -           notebook_task:
        -             notebook_path: ${var.notebook_root}/notebook_updated
        -+        - notebook_task:
        -+            notebook_path: ${var.notebook_root}/notebook_updated_sibling
        -+          task_key: added
        -       description: Remote description
        -
        -
         >>> [CLI] bundle destroy --auto-approve -qq
        +
        +Exit code: 1
TestAccept/bundle/config-remote-sync/task_rename_revert/DMS=: branch ✅ | main (5bda5d4) ❌ | latest (v1.23.0) ❌

main (5bda5d4):

acceptance_test.go:1342: Diff:
        --- bundle/config-remote-sync/task_rename_revert/output.txt
        +++ /tmp/TestAcceptbundleconfig-remote-synctask_rename_revertDMS=3430856489/002/output.txt
        @@ -6,47 +6,8 @@
         === Rename task to new_task_2 remotely
         
         === Sync the rename into config (no redeploy)
        -Detected changes in 1 resource(s):
        +Error: failed to resolve field changes: failed to resolve selectors in path resources.jobs.sample job's"quotes.tasks[task_key='new_task']: failed to parse path resources.jobs.sample job's"quotes.tasks[task_key='new_task']: invalid character ' ' in field name at position 21
         
        -Resource: resources.jobs.sample job's"quotes
        -  tasks[task_key='new_task']: remove
        -  tasks[task_key='new_task_2']: add
        -
        -
        -
        ->>> diff.py databricks.yml.backup databricks.yml
        ---- databricks.yml.backup
        -+++ databricks.yml
        -@@ -6,5 +6,5 @@
        -     "sample job's\"quotes":
        -       tasks:
        --        - task_key: new_task
        -+        - task_key: new_task_2
        -           notebook_task:
        -             notebook_path: /Users/{{workspace_user_name}}/new_task
        -
        -=== Rename task back to new_task remotely
        -
        -=== Sync the revert into config
        -Detected changes in 1 resource(s):
        -
        -Resource: resources.jobs.sample job's"quotes
        -  tasks[task_key='new_task']: add
        -  tasks[task_key='new_task_2']: remove
        -
        -
        -
        ->>> diff.py databricks.yml.backup databricks.yml
        ---- databricks.yml.backup
        -+++ databricks.yml
        -@@ -6,5 +6,5 @@
        -     "sample job's\"quotes":
        -       tasks:
        --        - task_key: new_task_2
        -+        - task_key: new_task
        -           notebook_task:
        -             notebook_path: /Users/{{workspace_user_name}}/new_task
        -
         >>> [CLI] bundle destroy --auto-approve
         The following resources will be deleted:
           delete resources.jobs.sample job's"quotes
        @@ -54,3 +14,5 @@
         All files and directories at the following location will be deleted: /Workspace/Users/[USERNAME]/.bundle/test-bundle-[UNIQUE_NAME]/default
         
         Destroy: 1 deleted
        +
        +Exit code: 1

latest (v1.23.0): same output as main (5bda5d4)

TestAccept/bundle/config-remote-sync/task_rename_revert/DMS=true: branch ✅ | main (5bda5d4) ❌ | latest (v1.23.0) ❌

main (5bda5d4):

acceptance_test.go:1342: Diff:
        --- bundle/config-remote-sync/task_rename_revert/output.txt
        +++ /tmp/TestAcceptbundleconfig-remote-synctask_rename_revertDMS=true693676298/002/output.txt
        @@ -6,47 +6,8 @@
         === Rename task to new_task_2 remotely
         
         === Sync the rename into config (no redeploy)
        -Detected changes in 1 resource(s):
        +Error: failed to resolve field changes: failed to resolve selectors in path resources.jobs.sample job's"quotes.tasks[task_key='new_task']: failed to parse path resources.jobs.sample job's"quotes.tasks[task_key='new_task']: invalid character ' ' in field name at position 21
         
        -Resource: resources.jobs.sample job's"quotes
        -  tasks[task_key='new_task']: remove
        -  tasks[task_key='new_task_2']: add
        -
        -
        -
        ->>> diff.py databricks.yml.backup databricks.yml
        ---- databricks.yml.backup
        -+++ databricks.yml
        -@@ -6,5 +6,5 @@
        -     "sample job's\"quotes":
        -       tasks:
        --        - task_key: new_task
        -+        - task_key: new_task_2
        -           notebook_task:
        -             notebook_path: /Users/{{workspace_user_name}}/new_task
        -
        -=== Rename task back to new_task remotely
        -
        -=== Sync the revert into config
        -Detected changes in 1 resource(s):
        -
        -Resource: resources.jobs.sample job's"quotes
        -  tasks[task_key='new_task']: add
        -  tasks[task_key='new_task_2']: remove
        -
        -
        -
        ->>> diff.py databricks.yml.backup databricks.yml
        ---- databricks.yml.backup
        -+++ databricks.yml
        -@@ -6,5 +6,5 @@
        -     "sample job's\"quotes":
        -       tasks:
        --        - task_key: new_task_2
        -+        - task_key: new_task
        -           notebook_task:
        -             notebook_path: /Users/{{workspace_user_name}}/new_task
        -
         >>> [CLI] bundle destroy --auto-approve
         The following resources will be deleted:
           delete resources.jobs.sample job's"quotes
        @@ -54,3 +14,5 @@
         All files and directories at the following location will be deleted: /Workspace/Users/[USERNAME]/.bundle/test-bundle-[UNIQUE_NAME]/default
         
         Destroy: 1 deleted
        +
        +Exit code: 1

latest (v1.23.0):

acceptance_test.go:1342: Diff:
        --- bundle/config-remote-sync/task_rename_revert/output.txt
        +++ /tmp/TestAcceptbundleconfig-remote-synctask_rename_revertDMS=true3824852980/002/output.txt
        @@ -6,47 +6,8 @@
         === Rename task to new_task_2 remotely
         
         === Sync the rename into config (no redeploy)
        -Detected changes in 1 resource(s):
        +Error: failed to resolve field changes: failed to resolve selectors in path resources.jobs.sample job's"quotes.tasks[task_key='new_task']: failed to parse path resources.jobs.sample job's"quotes.tasks[task_key='new_task']: invalid character ' ' in field name at position 21
         
        -Resource: resources.jobs.sample job's"quotes
        -  tasks[task_key='new_task']: remove
        -  tasks[task_key='new_task_2']: add
        -
        -
        -
        ->>> diff.py databricks.yml.backup databricks.yml
        ---- databricks.yml.backup
        -+++ databricks.yml
        -@@ -6,5 +6,5 @@
        -     "sample job's\"quotes":
        -       tasks:
        --        - task_key: new_task
        -+        - task_key: new_task_2
        -           notebook_task:
        -             notebook_path: /Users/{{workspace_user_name}}/new_task
        -
        -=== Rename task back to new_task remotely
        -
        -=== Sync the revert into config
        -Detected changes in 1 resource(s):
        -
        -Resource: resources.jobs.sample job's"quotes
        -  tasks[task_key='new_task']: add
        -  tasks[task_key='new_task_2']: remove
        -
        -
        -
        ->>> diff.py databricks.yml.backup databricks.yml
        ---- databricks.yml.backup
        -+++ databricks.yml
        -@@ -6,5 +6,5 @@
        -     "sample job's\"quotes":
        -       tasks:
        --        - task_key: new_task_2
        -+        - task_key: new_task
        -           notebook_task:
        -             notebook_path: /Users/{{workspace_user_name}}/new_task
        -
         >>> [CLI] bundle destroy --auto-approve
         The following resources will be deleted:
           delete resources.jobs.sample job's"quotes
        @@ -54,3 +14,5 @@
         All files and directories at the following location will be deleted: /Workspace/Users/[USERNAME]/.bundle/test-bundle-[UNIQUE_NAME]/default
         
         Destroy: 1 deleted
        +
        +Exit code: 1
        
FAIL

@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Nov 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: 14b9e68

Run: 41826901064

Env ✅​pass 🙈​skip Time
✅​ aws linux-2core-8gb 274 16 5:19
✅​ aws-windows-latest-4core-16gb 273 15 3:38
✅​ azure linux-2core-8gb 273 16 4:52
✅​ azure-windows-latest-4core-16gb 272 15 3:38
✅​ gcp linux-2core-8gb 274 16 5:19
✅​ gcp-windows-latest-4core-16gb 273 15 3:44
Top 3 slowest tests (at least 2 minutes):
duration env testname
3:27 azure-windows-latest-4core-16gb TestAccept
3:17 aws-windows-latest-4core-16gb TestAccept
3:16 gcp-windows-latest-4core-16gb TestAccept

@ilyakuz-db
ilyakuz-db added this pull request to the merge queue Nov 4, 2026
Merged via the queue into main with commit 382743b Nov 4, 2026
27 checks passed
@ilyakuz-db
ilyakuz-db deleted the ilyakuz-db/fix-config-sync-resource-keys branch November 4, 2026 12:37
denik
denik reviewed Nov 4, 2026
View reviewed changes
Comment thread bundle/configsync/resolve.go
for _, fieldPath := range fieldPaths {
configChange := resourceChanges[fieldPath]
fullPath := resourceKey + "." + fieldPath
fullPath := resourcePath.String() + "." + fieldPath

@denik denik Nov 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems you can have ther same issue with fieldPath? you can do structpath.StringKey(resourcePath, fieldPath).String() for reliable representation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@denik denik denik left review comments
@shreyas-goenka shreyas-goenka shreyas-goenka approved these changes

Assignees

No one assigned

Labels

ai-assisted DABs DABs related issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ilyakuz-db @eng-dev-ecosystem-bot @denik @shreyas-goenka