Repository navigation
Conversation
The browser login run after "Create a new profile" in `auth token` used the hardcoded one hour defaultTimeout instead of the --timeout flag, because profile resolution happens before loadToken applies args.tokenTimeout. Pass the flag value through resolveNoArgsToken to runInlineLogin, as `auth login` does with its own --timeout. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: 73e9fb2
Top 3 slowest tests (at least 2 minutes):
|
--timeout now also limits the inline browser login, so say so in the help text. Add a changelog entry, as other fixes to this login flow do. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
maksim-zuev-db
approved these changes
Nov 5, 2026
maksim-zuev-db
left a comment
maksim-zuev-db
left a comment
Member
There was a problem hiding this comment.
The "Why" in the description is a bit wrong, the better wording would be "#7267 made the inline login honor a timeout, but hard-coded defaultTimeout; this PR uses --timeout instead."
All the rest looks good, thanks!
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
databricks auth token --timeoutdidn't apply to the browser login after "Create a new profile" in the profile picker:runInlineLoginused a fixed one-hour timeout. It now uses the flag, likeauth login --timeout, and the flag's help text says so.Why
The inline login was added in #7267.
Tests
TestLoadTokenCreateNewProfileAppliesTimeoutdrives the picker against a server that never answers the login and expects the deadline to fire.This pull request and its description were written by Isaac.