Repository navigation
Conversation
The report-failure step ran on any failure, so a failed workflow_dispatch run (for example a mistyped version input in bump-go-toolchain, or a non-dry-run manual run of bump-vuln-deps) opened an issue claiming the scheduled workflow failed and assigned seven people. Gate the step on github.event_name == 'schedule' in both workflows; this subsumes the !inputs.dry_run check in bump-vuln-deps. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: 2880490
Top 3 slowest tests (at least 2 minutes):
|
Contributor
Author
|
For manual testing of the workflow we want to create an issue on workflow_dispatch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The "Report failure" step in
bump-go-toolchain.yml(if: failure()) andbump-vuln-deps.yml(if: failure() && !inputs.dry_run) also ran for manualworkflow_dispatchruns, so a mistypedversioninput opened a "the scheduled workflow failed" issue and assigned seven people. Both now useif: failure() && github.event_name == 'schedule'; thereport-failureaction's description recommends the same gate.Question: in
bump-vuln-deps.ymlthis drops!inputs.dry_run, so a failed manual non-dry-run no longer reports either, and the reporter can't be tested by dispatching a run by hand. Is schedule-only what we want?Why
Follow-up to #7312, which added the failure reporter.
Tests
This pull request and its description were written by Isaac.