Repository navigation
Conversation
Convert local paths to forward slashes with filepath.ToSlash in user-facing messages (diagnostic locations, YAML/JSON load errors, variable overrides file errors, glob errors, duplicate library names, sync root errors, git root errors, filer errors) and in diff.py output. Remove acceptance Repls that normalized backslashes and are no longer needed. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
Author
|
Cases left out of this PR (risky or not CLI output):
I removed Repls from a few cloud-only tests based on reading the code: cmd/fs/cp/file-to-nonexistent-dir, bundle/generate/genie_space, integration_whl/serverless, integration_whl/serverless_dynamic_version. PR CI can't check these on Windows. |
Contributor
|
Commit: Regression test reportSelected 20 changed tests (limit=20, 2 not selected) 36 tests: regression=0 unreleased=0 coverage=36 failing=0
|
Collaborator
✅ Integration test reportCommit: 342aff2
Top 3 slowest tests (at least 2 minutes):
|
…og golden The removed backslash Repl was also rewriting escaped \n and \" in notebook JSON into /n and /". Co-authored-by: Isaac <no-reply@databricks.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Wrap local paths with
filepath.ToSlashin user-facing messages: diagnostic locations (diag.Location.String, which covers YAML/JSON load errors), config load/rewrite errors, variable-overrides file errors, artifact glob errors, duplicate library names, the bundle-root glob check, the sync-root check, the git repository-root check and filer errors.acceptance/bin/diff.pynow prints POSIX paths too.Remove the backslash
Replsfrom acceptance tests that no longer need them. Some were already stale (docker host, apps/init, genie_space generate, integration_whl/serverless*, overrides_file_complex_path, nil_artifacts, wrong-url).Why
This is a follow-up to #4528. Output is the same on every OS, so tests don't need per-test separator fixups.
Tests
Linux outputs are unchanged. The Windows cell runs the changed tests. Cases left out on purpose are listed in a comment below.
This pull request and its description were written by Isaac.