Repository navigation
Record deployment history for bundle resource bindings - #7400
Draft
shreyas-goenka wants to merge 27 commits into
Draft
shreyas-goenka wants to merge 27 commits into
shreyas-goenka wants to merge 27 commits into
Conversation
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas-goenka/record-bind-history
branch
from
November 9, 2026 07:59
c8357c9 to
938294b
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas-goenka/record-bind-history
branch
from
November 9, 2026 08:08
938294b to
2c7cf79
Compare
Collaborator
✅ Integration test reportCommit: 445c82f
Top 3 slowest tests (at least 2 minutes):
|
Contributor
|
Commit: Regression test reportSelected 6 changed tests (limit=20, 0 not selected) 11 tests: regression=3 unreleased=0 coverage=8 failing=0
TestAccept/bundle/dms/bind-history-failures/DMS=true: branch ✅ | main (4423656) ❌ | latest (v1.25.0) ❌main (4423656): latest (v1.25.0): same output as main (4423656) TestAccept/bundle/dms/bind-immutable/DMS=true: branch ✅ | main (4423656) ❌ | latest (v1.25.0) ❌main (4423656): latest (v1.25.0): same output as main (4423656) TestAccept/bundle/dms/bind-unbind/DMS=true: branch ✅ | main (4423656) ❌ | latest (v1.25.0) ❌main (4423656): latest (v1.25.0): |
shreyas-goenka
commented
Nov 9, 2026
| trace $CLI bundle deployment bind foo $NEW_PIPELINE_ID --auto-approve &> out.bind-success.txt | ||
| trace print_requests.py '^//import-file/' '^//workspace/' | ||
|
|
||
| trace $CLI bundle summary -o json | jq .resources > out.summary.json |
Contributor
Author
There was a problem hiding this comment.
added because now the summary contains deployment and version ID
shreyas-goenka
commented
Nov 9, 2026
| print_requests.py '^//import-file/' '^//workspace/delete' | ||
|
|
||
| trace $CLI bundle summary -o json > out.summary.json | ||
| trace $CLI bundle summary -o json | nostamp.py > out.summary.json |
Contributor
Author
There was a problem hiding this comment.
updated nostamp.py to scrub the deployment ID from the summary output as well.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Record successful
bundle deployment bindcommands asBINDoperations in DMS history, completing the version after remote state upload. History failures warn while state upload continues.The engine returns optional DMS metadata containing the bound resource and serial; nil means history is disabled. The phase publishes through the SDK without reopening StateDB or adding state writes. Bind does not stage files, so initial registration omits a snapshot path and existing deployment metadata is preserved.
Shared deployment lookup lives in
libs/dms. Includes the one-line fake-server feature support fix from #7407. First in a stack; #7401 adds unbind recording.Tests
bind-unbind,bind-history-failures, andbind-immutableacceptance cases pass.This PR was written by Codex.