Skip to content

Keep an explicit false on optional bundle config bools #7412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
denik wants to merge 5 commits into from
Open

Keep an explicit false on optional bundle config bools #7412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f90f6f9
Keep an explicit false on optional bundle config bools
denik Nov 9, 2026
be44f11
Add changelog entry
denik Nov 9, 2026
61966f0
Drop a redundant loop variable copy
denik Nov 9, 2026
a018a91
Require *bool for every bool in CLI config structs; cover all target …
denik Nov 9, 2026
9a113f7
Postgres and deployment bools: *bool instead of ForceSendFields
denik Nov 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .nextchanges/bundles/7412.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* Fixed an explicit `false` on optional boolean fields (`variables.*.sensitive`, `artifacts.*.dynamic_version`, `bundle.deployment.lock.force`, `workspace.azure_use_msi`, `replace_existing` on postgres endpoints, databases and roles, and the `experimental.*` flags) being dropped, which hid it from `bundle validate -o json` and kept a target from overriding `true` with it. ([#7412](https://github.com/databricks/cli/pull/7412))
4 changes: 2 additions & 2 deletions acceptance/bundle/refschema/output/postgres_branches.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ resources.postgres_branches.*.modified_status string INPUT
resources.postgres_branches.*.name string REMOTE
resources.postgres_branches.*.no_expiry bool ALL
resources.postgres_branches.*.parent string ALL
resources.postgres_branches.*.purge_on_delete bool INPUT STATE
resources.postgres_branches.*.replace_existing bool INPUT STATE
resources.postgres_branches.*.purge_on_delete *bool INPUT STATE
resources.postgres_branches.*.replace_existing *bool INPUT STATE
resources.postgres_branches.*.source_branch string ALL
resources.postgres_branches.*.source_branch_lsn string ALL
resources.postgres_branches.*.source_branch_time *time.Time ALL
Expand Down
2 changes: 1 addition & 1 deletion acceptance/bundle/refschema/output/postgres_databases.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ resources.postgres_databases.*.modified_status string INPUT
resources.postgres_databases.*.name string REMOTE
resources.postgres_databases.*.parent string ALL
resources.postgres_databases.*.postgres_database string ALL
resources.postgres_databases.*.replace_existing bool INPUT STATE
resources.postgres_databases.*.replace_existing *bool INPUT STATE
resources.postgres_databases.*.role string ALL
resources.postgres_databases.*.status *postgres.DatabaseDatabaseStatus REMOTE
resources.postgres_databases.*.status.database_id string REMOTE
Expand Down
2 changes: 1 addition & 1 deletion acceptance/bundle/refschema/output/postgres_endpoints.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ resources.postgres_endpoints.*.modified_status string INPUT
resources.postgres_endpoints.*.name string REMOTE
resources.postgres_endpoints.*.no_suspension bool ALL
resources.postgres_endpoints.*.parent string ALL
resources.postgres_endpoints.*.replace_existing bool INPUT STATE
resources.postgres_endpoints.*.replace_existing *bool INPUT STATE
resources.postgres_endpoints.*.settings *postgres.EndpointSettings ALL
resources.postgres_endpoints.*.settings.pg_settings map[string]string ALL
resources.postgres_endpoints.*.settings.pg_settings.* string ALL
Expand Down
2 changes: 1 addition & 1 deletion acceptance/bundle/refschema/output/postgres_projects.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ resources.postgres_projects.*.modified_status string INPUT
resources.postgres_projects.*.name string REMOTE
resources.postgres_projects.*.pg_version int ALL
resources.postgres_projects.*.project_id string ALL
resources.postgres_projects.*.purge_on_delete bool INPUT STATE
resources.postgres_projects.*.purge_on_delete *bool INPUT STATE
resources.postgres_projects.*.purge_time *time.Time REMOTE
resources.postgres_projects.*.status *postgres.ProjectStatus REMOTE
resources.postgres_projects.*.status.branch_logical_size_limit_bytes int64 REMOTE
Expand Down
2 changes: 1 addition & 1 deletion acceptance/bundle/refschema/output/postgres_roles.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ resources.postgres_roles.*.modified_status string INPUT
resources.postgres_roles.*.name string REMOTE
resources.postgres_roles.*.parent string ALL
resources.postgres_roles.*.postgres_role string ALL
resources.postgres_roles.*.replace_existing bool INPUT STATE
resources.postgres_roles.*.replace_existing *bool INPUT STATE
resources.postgres_roles.*.role_id string ALL
resources.postgres_roles.*.status *postgres.RoleRoleStatus REMOTE
resources.postgres_roles.*.status.attributes *postgres.RoleAttributes REMOTE
Expand Down
52 changes: 26 additions & 26 deletions acceptance/bundle/refschema/output/root.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ __locations.version int INPUT
artifacts config.Artifacts INPUT
artifacts.* *config.Artifact INPUT
artifacts.*.build string INPUT
artifacts.*.dynamic_version bool INPUT
artifacts.*.dynamic_version *bool INPUT
artifacts.*.executable exec.ExecutableType INPUT
artifacts.*.files []config.ArtifactFile INPUT
artifacts.*.files[*] config.ArtifactFile INPUT
Expand All @@ -29,11 +29,11 @@ bundle.compute_id string INPUT
bundle.databricks_cli_version string INPUT
bundle.deployment config.Deployment INPUT
bundle.deployment.deployment_id string INPUT
bundle.deployment.fail_on_active_runs bool INPUT
bundle.deployment.fail_on_active_runs *bool INPUT
bundle.deployment.latest_version_id int INPUT
bundle.deployment.lock config.Lock INPUT
bundle.deployment.lock.enabled *bool INPUT
bundle.deployment.lock.force bool INPUT
bundle.deployment.lock.force *bool INPUT
bundle.engine engine.EngineType INPUT
bundle.environment string INPUT
bundle.force bool INPUT
Expand All @@ -55,7 +55,7 @@ environments.* *config.Target INPUT
environments.*.artifacts config.Artifacts INPUT
environments.*.artifacts.* *config.Artifact INPUT
environments.*.artifacts.*.build string INPUT
environments.*.artifacts.*.dynamic_version bool INPUT
environments.*.artifacts.*.dynamic_version *bool INPUT
environments.*.artifacts.*.executable exec.ExecutableType INPUT
environments.*.artifacts.*.files []config.ArtifactFile INPUT
environments.*.artifacts.*.files[*] config.ArtifactFile INPUT
Expand All @@ -75,11 +75,11 @@ environments.*.bundle.compute_id string INPUT
environments.*.bundle.databricks_cli_version string INPUT
environments.*.bundle.deployment config.Deployment INPUT
environments.*.bundle.deployment.deployment_id string INPUT
environments.*.bundle.deployment.fail_on_active_runs bool INPUT
environments.*.bundle.deployment.fail_on_active_runs *bool INPUT
environments.*.bundle.deployment.latest_version_id int INPUT
environments.*.bundle.deployment.lock config.Lock INPUT
environments.*.bundle.deployment.lock.enabled *bool INPUT
environments.*.bundle.deployment.lock.force bool INPUT
environments.*.bundle.deployment.lock.force *bool INPUT
environments.*.bundle.engine engine.EngineType INPUT
environments.*.bundle.environment string INPUT
environments.*.bundle.force bool INPUT
Expand All @@ -97,7 +97,7 @@ environments.*.bundle.terraform.exec_path string INPUT
environments.*.bundle.uuid string INPUT
environments.*.cluster_id string INPUT
environments.*.compute_id string INPUT
environments.*.default bool INPUT
environments.*.default *bool INPUT
environments.*.git config.Git INPUT
environments.*.git.actual_branch string INPUT
environments.*.git.branch string INPUT
Expand Down Expand Up @@ -148,7 +148,7 @@ environments.*.variables.*.lookup.pipeline string INPUT
environments.*.variables.*.lookup.query string INPUT
environments.*.variables.*.lookup.service_principal string INPUT
environments.*.variables.*.lookup.warehouse string INPUT
environments.*.variables.*.sensitive bool INPUT
environments.*.variables.*.sensitive *bool INPUT
environments.*.variables.*.type variable.VariableType INPUT
environments.*.variables.*.value any INPUT
environments.*.workspace *config.Workspace INPUT
Expand All @@ -159,7 +159,7 @@ environments.*.workspace.azure_client_id string INPUT
environments.*.workspace.azure_environment string INPUT
environments.*.workspace.azure_login_app_id string INPUT
environments.*.workspace.azure_tenant_id string INPUT
environments.*.workspace.azure_use_msi bool INPUT
environments.*.workspace.azure_use_msi *bool INPUT
environments.*.workspace.azure_workspace_resource_id string INPUT
environments.*.workspace.client_id string INPUT
environments.*.workspace.current_user *config.User INPUT
Expand Down Expand Up @@ -204,7 +204,7 @@ environments.*.workspace.current_user.schemas []iam.UserSchema INPUT
environments.*.workspace.current_user.schemas[*] iam.UserSchema INPUT
environments.*.workspace.current_user.short_name string INPUT
environments.*.workspace.current_user.userName string INPUT
environments.*.workspace.experimental_is_unified_host bool INPUT
environments.*.workspace.experimental_is_unified_host *bool INPUT
environments.*.workspace.file_path string INPUT
environments.*.workspace.google_service_account string INPUT
environments.*.workspace.host string INPUT
Expand All @@ -217,19 +217,19 @@ environments.*.workspace.sync_mode config.SyncMode INPUT
environments.*.workspace.workspace_id string INPUT
experimental *config.Experimental INPUT
experimental.deployment_history *bool INPUT
experimental.immutable_folder bool INPUT
experimental.immutable_folder *bool INPUT
experimental.pydabs config.PyDABs INPUT
experimental.pydabs.enabled bool INPUT
experimental.pydabs.enabled *bool INPUT
experimental.python config.Python INPUT
experimental.python.mutators []string INPUT
experimental.python.mutators[*] string INPUT
experimental.python.venv_path string INPUT
experimental.python_wheel_wrapper bool INPUT
experimental.python_wheel_wrapper *bool INPUT
experimental.scripts map[config.ScriptHook]config.Command INPUT
experimental.scripts.* config.Command INPUT
experimental.skip_artifact_cleanup bool INPUT
experimental.skip_name_prefix_for_schema bool INPUT
experimental.use_legacy_run_as bool INPUT
experimental.skip_artifact_cleanup *bool INPUT
experimental.skip_name_prefix_for_schema *bool INPUT
experimental.use_legacy_run_as *bool INPUT
include []string INPUT
include[*] string INPUT
permissions []resources.Permission INPUT
Expand Down Expand Up @@ -272,7 +272,7 @@ targets.* *config.Target INPUT
targets.*.artifacts config.Artifacts INPUT
targets.*.artifacts.* *config.Artifact INPUT
targets.*.artifacts.*.build string INPUT
targets.*.artifacts.*.dynamic_version bool INPUT
targets.*.artifacts.*.dynamic_version *bool INPUT
targets.*.artifacts.*.executable exec.ExecutableType INPUT
targets.*.artifacts.*.files []config.ArtifactFile INPUT
targets.*.artifacts.*.files[*] config.ArtifactFile INPUT
Expand All @@ -292,11 +292,11 @@ targets.*.bundle.compute_id string INPUT
targets.*.bundle.databricks_cli_version string INPUT
targets.*.bundle.deployment config.Deployment INPUT
targets.*.bundle.deployment.deployment_id string INPUT
targets.*.bundle.deployment.fail_on_active_runs bool INPUT
targets.*.bundle.deployment.fail_on_active_runs *bool INPUT
targets.*.bundle.deployment.latest_version_id int INPUT
targets.*.bundle.deployment.lock config.Lock INPUT
targets.*.bundle.deployment.lock.enabled *bool INPUT
targets.*.bundle.deployment.lock.force bool INPUT
targets.*.bundle.deployment.lock.force *bool INPUT
targets.*.bundle.engine engine.EngineType INPUT
targets.*.bundle.environment string INPUT
targets.*.bundle.force bool INPUT
Expand All @@ -314,7 +314,7 @@ targets.*.bundle.terraform.exec_path string INPUT
targets.*.bundle.uuid string INPUT
targets.*.cluster_id string INPUT
targets.*.compute_id string INPUT
targets.*.default bool INPUT
targets.*.default *bool INPUT
targets.*.git config.Git INPUT
targets.*.git.actual_branch string INPUT
targets.*.git.branch string INPUT
Expand Down Expand Up @@ -365,7 +365,7 @@ targets.*.variables.*.lookup.pipeline string INPUT
targets.*.variables.*.lookup.query string INPUT
targets.*.variables.*.lookup.service_principal string INPUT
targets.*.variables.*.lookup.warehouse string INPUT
targets.*.variables.*.sensitive bool INPUT
targets.*.variables.*.sensitive *bool INPUT
targets.*.variables.*.type variable.VariableType INPUT
targets.*.variables.*.value any INPUT
targets.*.workspace *config.Workspace INPUT
Expand All @@ -376,7 +376,7 @@ targets.*.workspace.azure_client_id string INPUT
targets.*.workspace.azure_environment string INPUT
targets.*.workspace.azure_login_app_id string INPUT
targets.*.workspace.azure_tenant_id string INPUT
targets.*.workspace.azure_use_msi bool INPUT
targets.*.workspace.azure_use_msi *bool INPUT
targets.*.workspace.azure_workspace_resource_id string INPUT
targets.*.workspace.client_id string INPUT
targets.*.workspace.current_user *config.User INPUT
Expand Down Expand Up @@ -421,7 +421,7 @@ targets.*.workspace.current_user.schemas []iam.UserSchema INPUT
targets.*.workspace.current_user.schemas[*] iam.UserSchema INPUT
targets.*.workspace.current_user.short_name string INPUT
targets.*.workspace.current_user.userName string INPUT
targets.*.workspace.experimental_is_unified_host bool INPUT
targets.*.workspace.experimental_is_unified_host *bool INPUT
targets.*.workspace.file_path string INPUT
targets.*.workspace.google_service_account string INPUT
targets.*.workspace.host string INPUT
Expand Down Expand Up @@ -449,7 +449,7 @@ variables.*.lookup.pipeline string INPUT
variables.*.lookup.query string INPUT
variables.*.lookup.service_principal string INPUT
variables.*.lookup.warehouse string INPUT
variables.*.sensitive bool INPUT
variables.*.sensitive *bool INPUT
variables.*.type variable.VariableType INPUT
variables.*.value any INPUT
workspace config.Workspace INPUT
Expand All @@ -460,7 +460,7 @@ workspace.azure_client_id string INPUT
workspace.azure_environment string INPUT
workspace.azure_login_app_id string INPUT
workspace.azure_tenant_id string INPUT
workspace.azure_use_msi bool INPUT
workspace.azure_use_msi *bool INPUT
workspace.azure_workspace_resource_id string INPUT
workspace.client_id string INPUT
workspace.current_user *config.User INPUT
Expand Down Expand Up @@ -505,7 +505,7 @@ workspace.current_user.schemas []iam.UserSchema INPUT
workspace.current_user.schemas[*] iam.UserSchema INPUT
workspace.current_user.short_name string INPUT
workspace.current_user.userName string INPUT
workspace.experimental_is_unified_host bool INPUT
workspace.experimental_is_unified_host *bool INPUT
workspace.file_path string INPUT
workspace.google_service_account string INPUT
workspace.host string INPUT
Expand Down
107 changes: 107 additions & 0 deletions acceptance/bundle/validate/explicit_false/databricks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,107 @@
bundle:
name: test-bundle
deployment:
fail_on_active_runs: true
lock:
force: true

workspace:
azure_use_msi: true

variables:
plain:
default: x
sensitive: false

artifacts:
whl:
type: whl
build: "true"
dynamic_version: false
overridden:
type: whl
build: "true"
dynamic_version: true

presets:
artifacts_dynamic_version: true

resources:
dashboards:
d:
display_name: d
warehouse_id: w
embed_credentials: true
postgres_projects:
p:
project_id: p
purge_on_delete: true
postgres_branches:
b:
parent: ${resources.postgres_projects.p.name}
branch_id: b
no_expiry: true
purge_on_delete: true
replace_existing: true
postgres_endpoints:
e:
parent: ${resources.postgres_branches.b.name}
endpoint_id: e
endpoint_type: ENDPOINT_TYPE_READ_WRITE
replace_existing: true
postgres_roles:
r:
parent: ${resources.postgres_branches.b.name}
role_id: r
postgres_role: app_role
replace_existing: true
postgres_databases:
db:
parent: ${resources.postgres_branches.b.name}
database_id: db
postgres_database: app_db
role: ${resources.postgres_roles.r.name}
replace_existing: true

experimental:
python_wheel_wrapper: false
use_legacy_run_as: false
skip_artifact_cleanup: false
skip_name_prefix_for_schema: false

targets:
dev:
default: true
# Each of these turns off what the root config turns on.
bundle:
deployment:
fail_on_active_runs: false
lock:
force: false
workspace:
azure_use_msi: false
artifacts:
overridden:
dynamic_version: false
presets:
artifacts_dynamic_version: false
resources:
dashboards:
d:
embed_credentials: false
postgres_projects:
p:
purge_on_delete: false
postgres_branches:
b:
purge_on_delete: false
replace_existing: false
postgres_endpoints:
e:
replace_existing: false
postgres_roles:
r:
replace_existing: false
postgres_databases:
db:
replace_existing: false
2 changes: 2 additions & 0 deletions acceptance/bundle/validate/explicit_false/out.test.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Cloud = false
EnvMatrix.DMS = ["", "true"]
Loading
Loading