Repository navigation
Add in_git_repo to bundle deploy and config-remote-sync telemetry - #7414
ilyakuz-db wants to merge 2 commits into
Conversation
Co-authored-by: Isaac <no-reply@databricks.com> Signed-off-by: ilya.kuznetsov <ilya.kuznetsov@databricks.com>
|
Commit: Regression test reportSelected 9 changed tests (limit=20, 0 not selected) 12 tests: regression=12 unreleased=0 coverage=0 failing=0
TestAccept/bundle/config-remote-sync/job_fields/DMS=: branch ✅ | main (943d3af) ❌ | latest (v1.25.0) ❌main (943d3af): latest (v1.25.0): same output as main (943d3af) TestAccept/bundle/config-remote-sync/job_fields/DMS=true: branch ✅ | main (943d3af) ❌ | latest (v1.25.0) ❌main (943d3af): latest (v1.25.0): same output as main (943d3af) TestAccept/bundle/config-remote-sync/resolve_variables/DMS=: branch ✅ | main (943d3af) ❌ | latest (v1.25.0) ❌main (943d3af): latest (v1.25.0): same output as main (943d3af) TestAccept/bundle/config-remote-sync/resolve_variables/DMS=true: branch ✅ | main (943d3af) ❌ | latest (v1.25.0) ❌main (943d3af): latest (v1.25.0): TestAccept/bundle/config-remote-sync/variable_reference_parent/DMS=: branch ✅ | main (943d3af) ❌ | latest (v1.25.0) ❌main (943d3af): latest (v1.25.0): same output as main (943d3af) TestAccept/bundle/config-remote-sync/variable_reference_parent/DMS=true: branch ✅ | main (943d3af) ❌ | latest (v1.25.0) ❌main (943d3af): latest (v1.25.0): TestAccept/bundle/telemetry/config-remote-sync-git/DMS=: branch ✅ | main (943d3af) ❌ | latest (v1.25.0) ❌main (943d3af): latest (v1.25.0): same output as main (943d3af) TestAccept/bundle/telemetry/config-remote-sync-recreate/DMS=: branch ✅ | main (943d3af) ❌ | latest (v1.25.0) ❌main (943d3af): latest (v1.25.0): same output as main (943d3af) TestAccept/bundle/telemetry/config-remote-sync-save/DMS=: branch ✅ | main (943d3af) ❌ | latest (v1.25.0) ❌main (943d3af): latest (v1.25.0): same output as main (943d3af) TestAccept/bundle/telemetry/config-remote-sync/DMS=: branch ✅ | main (943d3af) ❌ | latest (v1.25.0) ❌main (943d3af): latest (v1.25.0): same output as main (943d3af) TestAccept/bundle/telemetry/deploy-git/DMS=: branch ✅ | main (943d3af) ❌ | latest (v1.25.0) ❌main (943d3af): latest (v1.25.0): same output as main (943d3af) TestAccept/bundle/telemetry/deploy/DMS=: branch ✅ | main (943d3af) ❌ | latest (v1.25.0) ❌main (943d3af): latest (v1.25.0): same output as main (943d3af) |
✅ Integration test reportCommit: 3c347a5
Top 3 slowest tests (at least 2 minutes):
|
…sync in a git repo Co-authored-by: Isaac <no-reply@databricks.com> Signed-off-by: ilya.kuznetsov <ilya.kuznetsov@databricks.com>
Changes
Adds
in_git_repoto thebundle deployandbundle config-remote-synctelemetry events.load_git_detailsrecords whether a git repository (local.gitor a Databricks Git folder) was found, independent ofbundle.gitoverrides. It's sent as an explicitfalsewhen there is no repository and omitted when git detection did not run or failed (e.g. the bundle failed to load).Why
We want to track how many bundles are deployed and synced from git. Universe proto: databricks-eng/universe#3015975. Ingestion drops unknown fields, so the two PRs can land in either order.
Tests
Acceptance tests:
deploy-gitand the newconfig-remote-sync-gitreporttrueinside a git repo, the other deploy and config-remote-sync tests reportfalse, and runs that fail to load the bundle omit the field.This pull request and its description were written by Isaac.