-
Notifications
You must be signed in to change notification settings - Fork 145
feat(kernel): route Azure Entra auth (azure-sp-m2m + azure-oauth) through the auth bridge #919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eric-wang-1990
wants to merge
17
commits into
main
Choose a base branch
from
eric-wang/kernel-azure-oauth
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
8f2a73a
feat(kernel): thread Azure Entra OAuth (U2M + SP M2M) through the aut…
eric-wang-1990 c2dec51
docs: update CONNECTION_PARAMETERS.md for kernel Azure OAuth support
eric-wang-1990 01acb39
refactor(kernel): thin azure-oauth — kernel owns Azure resolution
eric-wang-1990 311e3f0
refactor(kernel): thin azure-sp-m2m — kernel owns Azure resolution + …
eric-wang-1990 dbf2b5a
refactor(kernel): drop azure-sp-m2m management token on the kernel path
eric-wang-1990 9e6ffe9
refactor(kernel): reject azure-oauth on the kernel path; point to dat…
eric-wang-1990 b121efd
feat(kernel): forward azure_workspace_resource_id for complete Azure …
eric-wang-1990 60adcaf
docs(kernel): azure-sp-m2m management token is gated on azure_workspa…
eric-wang-1990 b9290eb
feat(kernel): route azure-oauth (Azure AD U2M) to the kernel OAuth U2…
eric-wang-1990 463794c
Merge origin/main into eric-wang/kernel-azure-oauth
eric-wang-1990 8aee895
ai: apply changes for #919 (2 review threads)
peco-engineer-bot[bot] c3eacf7
ai: apply changes for #919 (1 review thread)
peco-engineer-bot[bot] 0fe8462
ai: apply changes for #919 (1 review thread)
peco-engineer-bot[bot] e0858b5
ai: apply changes for #919 (1 review thread)
peco-engineer-bot[bot] 1319dda
ai: apply changes for #919 (1 review thread)
peco-engineer-bot[bot] 7b5ae90
ci(kernel): bump KERNEL_REV to the build carrying the pyo3 Azure SP s…
eric-wang-1990 c344325
ai: apply changes for #919 (1 review thread)
peco-engineer-bot[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 9e3dbf9c40733b176151e001c9a15202030b967a | ||
| ad78a5be3dc8bb7fc78ec574492515ab24e23d4c |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
azure-oauth for Kernel mode is same with databricks-oauth, which is inHouse OAuth U2M
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed — and the doc already states exactly this. CONNECTION_PARAMETERS.md:72 says azure-oauth on the kernel path "routes to the kernel's OAuth U2M flow identically to databricks-oauth (the in-house workspace-federated browser flow, which Azure workspaces support)." That matches your point that kernel-mode azure-oauth is the same in-house OAuth U2M as databricks-oauth, so no change is needed.