Climate trace ghg emission - manifest file correction - #1928
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing data clarity by modifying the import name within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the import_name in the manifest.json for the Climate Trace import to be more descriptive. While the new name is an improvement in specificity, I have one suggestion regarding the naming convention to improve consistency.
|
LGTM |
|
/gcbrun |
|
/gcbrun |
dbb3ceb to
a126bfb
Compare
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
Summary of Changes
This PR updates the Climate Trace GHG emissions import configuration, enhances the download pipeline reliability, and refines schema mappings:
Manifest Corrections (
manifest.json):import_nameto match the canonical production specification (ClimateTrace_GHG_Emissions).--output_countersfor both sector and subsector processing, and retained operational counters undersource_files: ["counters/*.csv", "input_files/*"]for GCS validation and tracking.node_mcf: "output/*.mcf"underimport_inputsto properly ingest generated schema definitions.Downloader Improvements (
download_and_segregate_by_gas.py):timeout=60) and dynamic script directory path resolution.emissions_quantitynumeric values to avoid scientific notation.Schema & PV Mapping (
climate_pvmap_subsectors.csv):removalsto the newEmissionRemovalsschema property.Documentation (
README.md):Auto Data refresh cl for climate trace ghg emissions
BEGIN_PUBLIC
Auto Data refresh cl for climate trace ghg emissions
END_PUBLIC
SUMMARY_REPORT=https://storage.mtls.cloud.google.com/unresolved_mcf/climate_trace/gas/latest/summary_report.html
LATEST_VERSION_NOTE=The latest version file has the required timestamp.
VALIDATION=https://dashboards.corp.google.com/_51d0e7ea_3666_4fe8_82a6_acbf24d2585f?p=CNSPATH:%2Fcns%2Fjv-d%2Fhome%2Fdatcom%2Fv3_mcf%2Fclimate_trace%2Fgas%2Flatest%2Fstats_checker_ClimateTrace_GHG_Emissions_20260428_20080%2Fvalidation_proto@100
DIFFER_NOTE=The differ has deletions due to change in series.
REPORT_JSON=https://storage.mtls.cloud.google.com/unresolved_mcf/climate_trace/gas/latest/report.json
VALIDATION_NOTE=The dashboard shows duplicates, but the output does not have duplicate observations
IMPORT_DOC=https://docs.google.com/document/d/1bzP5YWI4cLksY1Qn2i7DF9GUDfwn35HYwKcuyVZY1f0/edit?resourcekey=0-pC6V-J6pyH6NNwfcL7jPXA&tab=t.oahequpnawau
TESTED=dc-import lint on MCF
DIFFER=https://dashboards.corp.google.com/datacommons_dashboard_cache_differ_dashboard?p=IMPORTNAME:ClimateTrace_GHG_Emissions&p=CNSPATH:%2Fcns%2Fjv-d%2Fhome%2Fdatcom%2Fv3_mcf%2Fclimate_trace%2Fgas%2Flatest%2Fimport_differ_ClimateTrace_GHG_Emissions_20260428_29044%2Fstore@*