code fix & added goldens in USCensusPEP_AgeSexRaceHispanicOrigin - #2134
code fix & added goldens in USCensusPEP_AgeSexRaceHispanicOrigin#2134niveditasing wants to merge 11 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces validation configurations and golden data files for the US Census PEP ASRH import, including adding a validation_config.json and updating the manifest. Additionally, the download script pep_asrh_download_script.py was updated to include a polite delay and a custom User-Agent header when making requests. The review feedback correctly identifies that the time module is imported locally inside functions and loops, which violates PEP 8 guidelines, and recommends moving the import to the top of the file.
| @@ -0,0 +1,2096 @@ | |||
| "observationAbout" | |||
There was a problem hiding this comment.
I see summary report file size being very huge. Can you confirm if whether we have generated the goldens using the latest method where only nl SVs are taken in consideration.
Python Code Fixes (pep_asrh_download_script.py)
Testing Results: https://storage.mtls.cloud.google.com/datcom-import-test/statvar_imports/us_census/pep/us_census_pep_asrh/USCensusPEP_AgeSexRaceHispanicOrigin/2026_08_05T01_31_50_889195_07_00/input0/validation/validation_output.csv