Made changes in the manifest file - #2180
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the manifest.json for the India RBI State Domestic Product import by adding new parameters to the stat_var_processor.py script, tracking counter files, and adding a node_mcf field. The feedback suggests specifying the exact path for the generated MCF file in node_mcf instead of using a wildcard to prevent matching unrelated files and ensure better compatibility.
Krishnam24maheshwari
changed the title
Krishnam24maheshwari
left a comment
Krishnam24maheshwari
left a comment
There was a problem hiding this comment.
Done changes as per Gemini bot
| ], | ||
| "import_inputs": [ | ||
| { | ||
| "template_mcf": "output/state_domestic_product_output.tmcf", | ||
| "cleaned_csv": "output/state_domestic_product_output.csv" | ||
| "cleaned_csv": "output/state_domestic_product_output.csv", | ||
| "node_mcf": "output/*.mcf" |
There was a problem hiding this comment.
Adding node_mcf is fine, but we have to raise CL as well to bring defination of those 5 SVs
2 participants
In the import, Out of the 34 Statistical Variables generated in the dataset (totaling 15,435 rows), exactly 5 StatVars account for all 2,271 missing reference errors.
1. RealValue_Amount_EconomicActivity_NetDomesticProduction_PerCapita
2. RealValue_Amount_EconomicActivity_GrossValueAdded_FinancialServices
3. RealValue_Amount_EconomicActivity_NetValueAdded_FinancialServices
4. Nominal_Amount_EconomicActivity_GrossValueAdded_FinancialServices
5. Nominal_Amount_EconomicActivity_NetValueAdded_FinancialServices
In manifest.json, import_inputs does not specifies "node_mcf": "output/*.mcf".
During the pipeline execution, no .mcf definitions for these 5 variables were uploaded/passed to the genmcf stage.
I have added "node_mcf" in the manifest json file so that definitions for those 5 StatVars will be available now during the genmcf stage.
Validation output - https://pantheon.corp.google.com/storage/browser/_details/datcom-import-test/statvar_imports/india_rbistatedomesticproduct/India_RBIStateDomesticProduct/2026_08_24T23_50_30_176912_07_00/input0/validation/validation_output.csv;tab=live_object?pageState=(%22StorageObjectListTable%22:(%22f%22:%22%255B%255D%22))&project=datcom-infosys-dev