Convert Rwanda Census import to semi-automatic - #2182
Open
rohitkumarbhagat wants to merge 2 commits into
Open
Conversation
Switch Rwanda census download to GCS and update manifest/README. Refactor xml_to_json to use absl.app and add unit tests for error handling.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Rwanda Census ingestion workflow by introducing a local GCS download script, updating the README documentation, and refining the manifest. It also refactors the xml_to_json.py utility to use absl.app and improves its test coverage. The review feedback recommends explicitly specifying UTF-8 encoding when opening files, using .strip() to robustly handle whitespace-only XML files, avoiding noisy logging on CLI usage errors, and adding a unit test for empty inputs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rwanda_Censusimport to semi-automatic by updatingmanifest.jsonand adding GCS-baseddownload.sh.README.md.util/xml_to_json.pyto useabsl.appand add unit tests inutil/xml_to_json_test.py.