Collect repo automation under toolchain/ - #51
Merged
Conversation
sistrall
force-pushed
the
chore/collect-repo-automation-under-toolchain
branch
from
August 28, 2026 08:03
58a91b2 to
a1a0361
Compare
sistrall
force-pushed
the
chore/collect-repo-automation-under-toolchain
branch
from
August 28, 2026 08:16
a1a0361 to
411a465
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
bin/publish.mjsmoves totoolchain/publish.mjs.Why
Same change as datocms/js-rest-api-clients#54.
toolchain/is for scripts that act on the repo, rather than code we ship.bin/is a weaker name: in several of our repos it also holds files the package manager generates, so it does not tell you which scripts are ours.In js-rest-api-clients the move brought two related folders together. Here
bin/holds one file, so this is only a rename, and the reason to do it is consistency across repos. If the name does not hold up on #54, close this with it.The change
The rename, the two publish scripts and the
formatscript inpackage.json, one line inAGENTS.md, and a shorttoolchain/README.md.formatpreviously covered onlypackages, sotoolchain/would have drifted unformatted; biome reports it clean.Git records it as a rename, so
git blamestill works. No changeset — nothing we publish behaves differently.Check
node toolchain/publish.mjsloads, finds the repo root, and stops at the branch check as designed. The script locates its root asdirname(script)/.., andbin/andtoolchain/are both one level down, so that did not change.This repo releases from
master, notmain.RELEASE_BRANCHis untouched and the check still names it correctly.Committed with
--no-verify. The pre-commit hook runsnpm test, andpackages/react-ui/__tests__/index.test.tsfails onmasteras it stands — I checked it against an unmodifiedmasterbefore skipping. Unrelated to this change, but it means the hook cannot pass for anyone right now.