Solution Update - #362
Open
WindowsNT wants to merge 3 commits into
Open
Conversation
WindowsNT
commented
Sep 1, 2026
- Static Builds
- All cpps in place
- /MP added
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Visual Studio solution project files to better support Windows/MSBuild builds by standardizing static CRT usage and enabling multi-processor compilation, while also aligning project file lists (e.g., adding newly needed .cpp sources) and cleaning up formatting.
Changes:
- Switch MSBuild projects to static runtime (
/MT+/MTd) via<RuntimeLibrary>MultiThreaded[Debug]</RuntimeLibrary>. - Enable multi-processor compilation (
/MP) via<MultiProcessorCompilation>true</MultiProcessorCompilation>. - Bring solution projects/filters in sync with sources (e.g., add
deal_fanout.cpp, removehands.cppfrom some.filters, removeDDS.vcxproj.filters).
Reviewed changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| solution/solve_board.vcxproj | Enable /MT + /MP and minor XML formatting cleanup. |
| solution/solve_board_pbn.vcxproj | Enable /MT + /MP and minor XML formatting cleanup. |
| solution/solve_all_boards.vcxproj | Enable /MT + /MP and minor XML formatting cleanup. |
| solution/par.vcxproj | Enable /MT + /MP and minor XML formatting cleanup. |
| solution/migration_example.vcxproj | Enable /MT + /MP and minor XML formatting cleanup. |
| solution/hands.vcxproj | Enable /MT + /MP for the hands static library. |
| solution/dealer_par.vcxproj | Enable /MT + /MP and minor XML formatting cleanup. |
| solution/dealer_par.vcxproj.filters | Remove hands.cpp entry from the project filters. |
| solution/DDS.vcxproj | Convert DDS project to static library settings and enable /MT + /MP; add system/deal_fanout.cpp. |
| solution/DDS.vcxproj.filters | Remove the DDS filters file (project organization only). |
| solution/dds_native.vcxproj | Enable /MT + /MP; add system/deal_fanout.cpp; minor formatting cleanup. |
| solution/dds_native.vcxproj.filters | Add system/deal_fanout.cpp to filters. |
| solution/calc_par_context_example.vcxproj | Reformat/normalize project XML; enable /MT + /MP. |
| solution/calc_par_context_example.vcxproj.filters | Remove hands.cpp entry from the project filters. |
| solution/calc_dd_table.vcxproj | Enable /MT + /MP and minor XML formatting cleanup. |
| solution/calc_dd_table.vcxproj.filters | Remove hands.cpp entry from the project filters. |
| solution/calc_all_tables.vcxproj | Enable /MT + /MP and minor XML formatting cleanup. |
| solution/calc_all_tables.vcxproj.filters | Remove hands.cpp entry from the project filters. |
| solution/calc_all_tables_pbn.vcxproj | Enable /MT + /MP and minor XML formatting cleanup. |
| solution/calc_all_tables_pbn.vcxproj.filters | Remove hands.cpp entry from the project filters. |
| solution/analyse_play_pbn.vcxproj | Enable /MT + /MP and minor XML formatting cleanup. |
| solution/analyse_play_pbn.vcxproj.filters | Remove hands.cpp entry from the project filters. |
| solution/analyse_play_bin.vcxproj | Enable /MT + /MP and minor XML formatting cleanup. |
| solution/analyse_play_bin.vcxproj.filters | Remove hands.cpp entry from the project filters. |
| solution/analyse_all_plays_bin.vcxproj | Enable /MT + /MP and minor XML formatting cleanup. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
|
@WindowsNT, CI should pass if you update your branch with the latest commits to develop. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.