Skip to content

Solution Update - #362

Open
WindowsNT wants to merge 3 commits into
dds-bridge:developfrom
WindowsNT:develop
Open

Solution Update#362
WindowsNT wants to merge 3 commits into
dds-bridge:developfrom
WindowsNT:develop

Conversation

@WindowsNT

Copy link
Copy Markdown
  1. Static Builds
  2. All cpps in place
  3. /MP added

WindowsNT and others added 3 commits August 31, 2026 10:48
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings September 1, 2026 16:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Visual Studio solution project files to better support Windows/MSBuild builds by standardizing static CRT usage and enabling multi-processor compilation, while also aligning project file lists (e.g., adding newly needed .cpp sources) and cleaning up formatting.

Changes:

  • Switch MSBuild projects to static runtime (/MT + /MTd) via <RuntimeLibrary>MultiThreaded[Debug]</RuntimeLibrary>.
  • Enable multi-processor compilation (/MP) via <MultiProcessorCompilation>true</MultiProcessorCompilation>.
  • Bring solution projects/filters in sync with sources (e.g., add deal_fanout.cpp, remove hands.cpp from some .filters, remove DDS.vcxproj.filters).

Reviewed changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated no comments.

Show a summary per file
File Description
solution/solve_board.vcxproj Enable /MT + /MP and minor XML formatting cleanup.
solution/solve_board_pbn.vcxproj Enable /MT + /MP and minor XML formatting cleanup.
solution/solve_all_boards.vcxproj Enable /MT + /MP and minor XML formatting cleanup.
solution/par.vcxproj Enable /MT + /MP and minor XML formatting cleanup.
solution/migration_example.vcxproj Enable /MT + /MP and minor XML formatting cleanup.
solution/hands.vcxproj Enable /MT + /MP for the hands static library.
solution/dealer_par.vcxproj Enable /MT + /MP and minor XML formatting cleanup.
solution/dealer_par.vcxproj.filters Remove hands.cpp entry from the project filters.
solution/DDS.vcxproj Convert DDS project to static library settings and enable /MT + /MP; add system/deal_fanout.cpp.
solution/DDS.vcxproj.filters Remove the DDS filters file (project organization only).
solution/dds_native.vcxproj Enable /MT + /MP; add system/deal_fanout.cpp; minor formatting cleanup.
solution/dds_native.vcxproj.filters Add system/deal_fanout.cpp to filters.
solution/calc_par_context_example.vcxproj Reformat/normalize project XML; enable /MT + /MP.
solution/calc_par_context_example.vcxproj.filters Remove hands.cpp entry from the project filters.
solution/calc_dd_table.vcxproj Enable /MT + /MP and minor XML formatting cleanup.
solution/calc_dd_table.vcxproj.filters Remove hands.cpp entry from the project filters.
solution/calc_all_tables.vcxproj Enable /MT + /MP and minor XML formatting cleanup.
solution/calc_all_tables.vcxproj.filters Remove hands.cpp entry from the project filters.
solution/calc_all_tables_pbn.vcxproj Enable /MT + /MP and minor XML formatting cleanup.
solution/calc_all_tables_pbn.vcxproj.filters Remove hands.cpp entry from the project filters.
solution/analyse_play_pbn.vcxproj Enable /MT + /MP and minor XML formatting cleanup.
solution/analyse_play_pbn.vcxproj.filters Remove hands.cpp entry from the project filters.
solution/analyse_play_bin.vcxproj Enable /MT + /MP and minor XML formatting cleanup.
solution/analyse_play_bin.vcxproj.filters Remove hands.cpp entry from the project filters.
solution/analyse_all_plays_bin.vcxproj Enable /MT + /MP and minor XML formatting cleanup.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@zzcgumn

zzcgumn commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

@WindowsNT, CI should pass if you update your branch with the latest commits to develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants