[virtualization] bump to v1.11.1 - #458
Draft
universal-itengineer wants to merge 1 commit into
Draft
Conversation
Pin src/cli and api to the 1.11 line. Both modules must move together: upstream src/cli/go.mod declares api as a placeholder resolved through the repository's go.work, which does not reach consumers. Until src/cli/v1.11.1 is tagged, both point at the release-1.11 head 6bd3a583. Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the
d8 vsubcommands off the pinnedfix/cli/mute-warnings-during-cobra-init-release-1-6-2revision and onto the 1.11 line of
github.com/deckhouse/virtualization/src/cli.What changed
src/cli:v0.0.0-20260411164351-43c8e331b69d→v0.0.0-20260826084353-6bd3a583bc4eapi:v1.5.1→v0.15.1-0.20260826084353-6bd3a583bc4eBoth modules move together and point at the same revision. Upstream
src/cli/go.moddeclares
apias the placeholderv0.0.0-00010101000000-000000000000and resolves itthrough the virtualization repository's
go.work, which does not reach consumers — so theconsumer picks the
apiversion, andgo mod tidycannot do it for us. Leavingapiatv1.5.1fails the build withundefined: v1alpha2.VMOPPhaseSupersededandundefined: subv1alpha2.VirtualMachineSession.The
apiversion number goes down (v1.5.1→v0.15.1-0...). Expected: theapimodulehas its own tag line, and the pseudo-version continues
api/v0.15.0.Also drops the stale
go.modcomment telling us to move to 1.8.0 "after updating Kubernetesto 0.34" —
k8s.io/*has been onv0.34.8since #383.Verification
task build— passestask lint:dev:check— 0 issues./bin/d8 v --help— subcommand list intact, now includingmigrate,ansible-inventory,collect-debug-info,port-forwardgo test ./cmd/... ./internal/...— one failure,TestTokenConfigured/noneininternal/strongholddiscovery. It reproduces on an unmodifiedmain(a stronghold tokenpresent in the local environment), so it is not from this change.
Notes
go getfor these two modules needsGOPROXY=direct.proxy.golang.orgdoes not servearbitrary revisions of the nested
src/climodule, and it fails the same way a wrong refdoes, which makes it easy to misdiagnose:
The same message appears when passing the branch name instead of a SHA —
go getfalls backto the root module. There is no
src/cli/v1.11.xtag to use instead; the newest issrc/cli/v1.8.0.Before merge
v1.11.1tags once they existrelease-1.11 branch headcomments ingo.modd8 v --help