[ci] Run PR checks on release branches (main) - #468
Open
Glitchy-Sheep wants to merge 1 commit into
Open
Conversation
For pull_request events GitHub reads the workflow from the merge ref of the PR, so this change on main does not affect the existing release branches. It makes sure every future release branch cut from main starts with the correct trigger filter. Existing branches are covered separately: #441 (release-0.32) and a sibling PR for release-0.30. Signed-off-by: Roman Berezkin <roman.berezkin@flant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PRs into release branches get no CI: the
pull_requesttrigger in.github/workflows/release.yamlmatches only basemain. Backports land by hand, which is the kind of change that most needs checks, and today a broken backport shows up only when the release tag is built (see #460 breaking thev0.30.22build, fixed by #461).Fix
Add
release-*to the trigger filter.For
pull_requestevents GitHub reads the workflow from the merge ref of the PR, i.e. from the base branch. So this change onmaindoes not affect the existing release branches - it makes sure every future release branch cut frommainstarts with the correct filter, so the problem does not come back.The existing branches are covered separately with the same one-liner: #441 for
release-0.32, #467 forrelease-0.30.