Repository navigation
R18検索の戻り値型の修正とビルダーの型テスト追加 - #256
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R18検索の
fields()が指定した取得項目だけを戻り値の型に反映するよう修正します。opt()で追加した項目の型も、呼び出し順序にかかわらず保持します。通常検索・R18検索・ユーザー検索・ランキングの公開APIについて、Node版とブラウザ版を対象とする型テストを追加しました。取得項目の絞り込み、readonly配列、メソッドチェーン、ランキングのオーバーロード、不正な項目の型エラーを検証します。既存のR18テストにも回帰検証を追加しています。
通常検索・R18検索とも、項目未指定時は
novel_type、of=nt指定時はnoveltypeが返る違いを、型テストと実APIテストで検証します。実行時の通信処理や検索条件の扱いは変更しません。型の厳密化により、R18検索で未取得の項目を参照していたコードにはコンパイルエラーが発生する可能性があります。
検証:
pnpm run check成功（725件成功・3件スキップ、実APIテストを含む）。pnpm run build:tsc成功。