Repository navigation
NarouNovelFetchにHTTPステータスの検証を追加 - #258
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTPステータスを確認せず本文を解析していたため、非2xxでも解析可能なJSONが返ると正常な結果として返していました。fetch直後にres.okを確認し、非2xxでは本文を読み取らず、ステータスコードとステータステキストを含むErrorでrejectします。
403・404・429・500についてgzip指定の有無にかかわらず本文を読まないことと、HTTP 200で返るプレーンテキストのAPIエラーが従来どおりrejectされることをテストしています。
検証: pnpm run check成功（lint・型チェック・実APIテストを含む698件成功、3件スキップ）。