Repository navigation
検索APIの出力型を修正し、既存動作の回帰テストを追加 - #259
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R18検索で実際には返されない
useridが取得項目と結果型に含まれ、ユーザー検索ではname1stがnullを返す場合もstringとして扱われていました。実APIの出力に合わせて型を修正します。userid出力定義を削除し、通常APIのuseridは維持UserSearchResult.name1stをstring | nullに修正検証:
pnpm run build成功（lint・型チェック・実APIを含む765件のテスト成功、既存3件スキップ、ESM/CJS・ブラウザ向けビルド成功）。R18の4掲載サイトの実API応答で、of未指定およびof=n-uにuserid・xidが含まれないことも確認済みです。