Repository navigation
検索ビルダーとfetchの既存挙動を固定する回帰テスト追加 - #262
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
検索条件の再指定やページ設定、圧縮設定省略時のエラー挙動を固定する回帰テストを追加します。既存 API の互換性を維持しながら、今後の設計変更による挙動の変化を検出できるようにします。
word・limitの再指定、fieldsの参照共有と再指定、pageの上書きと既定値を検証NarouNovelFetchの圧縮設定省略時も、既存の文字列エラーを維持することを検証テストは既存ファイルの機能別ブロックに配置しています。ライブラリ実装の変更はありません。
検証:
pnpm run check成功（Lint・型チェック・単体テスト、778件成功／3件スキップ）。