Repository navigation
Mark si and chi as possible surnames, not only credentials - #794
Merged
Merged
Conversation
si and chi were unambiguous post-nominals from the 2019 bulk import. Both are common surnames (Census 2010: Si 1,166, Chi 7,273), so they join the ambiguous set the way ba and meng did: a full name in front keeps the credential by the words-to-spare count, and a bare or comma-form one reads the name with the fork reported. Adds the #791 case rows, a dated decisions entry, a release-log bullet, and four shape-tagged rows (Luo Si, Min Chi, Wang, Si, Smith, Chi). No real corpus name holds si or chi. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Records the grid as re-runnable text (templates, names, credentials, comparator), fixes the Wang, Si Ming quote and the move count, states the removal reason on C-i's default, and restates the report-wording mismatch with what was measured. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #794 +/- ##
=======================================
Coverage 99.05% 99.05%
=======================================
Files 47 47
Lines 4642 4642
=======================================
Hits 4598 4598
Misses 44 44 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
- comma rows carry shape 2 (family comma); corpus_shapes regenerated - bearer counts recorded as family and given readings with as_of - empty-head, nickname-head, caps and family-first rows added - credential_run row renamed to _chi; stale 2026-10-18 date fixed - release-log #737 bullet qualified; #791 bullet names the Chi costs - decisions entry: Meng./Lac. wording stated as checked Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
…ase bullet (#794) - Wang, SI row renamed comma_capital_si_after_a_surname_is_a_suffix (it shared a name with the John Smith, SI row) - test_every_case_name_is_unique, with a recorded negative control - #791 release bullet trimmed to one before/after and the limits - #737 bullet reworded to the re-encoding: it changes no word list and no parse, so it no longer conflicts with #791's bullet Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
The uniqueness test had been inserted between the shape-tag comment block and its decorator; move it above the comment. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
This was referenced Oct 21, 2026
derek73
added a commit
that referenced
this pull request
Oct 22, 2026
#811) * Name the bound field in the comma report on a listed member (#793) After a family comma the listing form binds a marked member the reading declines as a title ('John, Si.', 'John, Ma.'), but its suffix-or-name report said "read as a credential". The report now names the role the comma bound: "read as a title" there, "read as a credential" for a suffix ('John, MA'). No reading moves. Adds the two rows the field test now checks (control: 6 parses fail with the old wording) and the #794 review's eleven rows pinning the #791 members in suffix runs, behind titles, all-lower and in non-trailing positions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Point decisions/A1 and C11 at #793's report fix (docs review) A1's #626 entry listed the comma's credential reading among reports worded where the field is settled; #793 showed the listing form binds it as a title. C11's history now reaches the entry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #791.
What changes
siandchiwere unambiguous post-nominals from the 2019 bulk import. Both are common surnames (US Census 2010: Si 1,166 family-name bearers, Chi 7,273; measured withtools/name_usage.pyon 2026-10-21), so they join the ambiguous set thatbaandmenguse (may_be_name = true,issue = 791). Their bearer counts sit infamilyandgivenreadings withas_of.Luo Sigives familySi, where 2.0.0 through 2.5.0 gave suffixSiwith no family name.Wang, Sigives givenSi, where those releases gave suffixSiwith no given name.Siafter a full name takes the family name, asMadoes (John Smith Si: middleSmith, familySi).SIafter a full name is still a credential:John Smith SIgives suffixSI, flagged.The ambiguity is reported (
suffix-or-name), so the caller can see the fork.Measured moves
siorchias a word, so the snapshot moves nothing. Four shape-tagged rows (Luo Si,Min Chi,Wang, Si,Smith, Chi) are new entries incorpus_shapes.jsonlandsnapshot.jsonl.GIVEN_FIRST, 100 underFAMILY_FIRST, 100 underFAMILY_FIRST_GIVEN_LAST. No moved word is dropped.John Smith SiandJohn Smith Si.read family (the ma/Ma shape, S6);John Smith Chi PhDstops at the declined pick;John, Si.reads title, asJohn, Ma.does;John Smith (Chi)reads nickname.John, Si.reports "read as a credential" while the word lands in the title field. Filed as Reports say "read as a credential" for a period-marked title after a comma #793 (Reports say "read as a credential" for a period-marked title after a comma #793). The field-naming test cannot take a row for it until that is fixed.Where it is recorded
nameparser/vocab/en.toml: the two entries, withfamilyandgivenreadings and notes, and the rebuilt_compiled.py.tests/v2/cases.py: 17#791rows, pinning the fork with the contrasting spellings (John Smith SI,John Smith, SI,John Smith S.I.), the empty and nickname heads, the caps lean, and the family-first roles.test_every_case_name_is_uniqueguards the table against repeated names.docs/design/decisions/suffix-acronym-collisions.md: a dated 2026-10-21 entry with the precedence (S6 before S4), the period behaviour, the accepted costs, and the order-grid recipe.docs/release_log.rst: a Behavior Changes bullet under 2.6.0; the Describe each word by its readings: per-word TOML vocabulary compiled to today's sets (phase 1) #737 bullet now says the re-encoding changes no word list and no parse.AGENTS.md: "a trailing period-marked word the UNAMBIGUOUS SUFFIX vocabulary knows is still a suffix".Checks
uv run pytest: 22,330 passed, 125 skipped, 3 xfailed.uv run mypyanduv run ruff check: clean.snapshot.pyandcldr_agreement.pymatch their records. The JA view needs namedivider, which is not installed locally; CI's ja-extra job runs it.b1907247andb23fb7b1; the remaining test gaps (suffix runs, all-lowercasesi, the absence contrast, a title head) are follow-ups.🤖 Generated with Claude Code