Repository navigation
fix: integrate scanner and widget lifetime corrections on current main - #7
ellmos-multi-bot wants to merge 4 commits into
Conversation
Author model: gpt-6.1-sol (Codex). Independent review pending.
Generated-with: gpt-6.1-sol (Codex)
Generated-with: gpt-6.1-sol (Codex)
|
Welcome! 👋 Thanks for your first pull request in this repository. A maintainer will review it soon. Please make sure:
Thanks for contributing! |
|
Author QA update, not an independent approval. Head 8b289f9 remains merge-HOLD. Current CI 39720458835: Windows/Python 3.10 job 119632528992 installed PySide6/shiboken6 6.11.2 and aborted with a native access violation at tests/test_find_in_files.py:243 ( The three source regressions and 15 focused tests are confirmed, but they do not establish full native acceptance. The additional local Windows/Python 3.12/PySide6 6.11.1 suite is still CPU-active, with stack samples showing progress between tests during global theme application; no full-suite success is claimed. It is bounded by the repository's existing 25-minute CI runtime limit. A separate observation of ten searches found all 30 unmodified dialog-handler calls on the GUI thread locally, so no speculative thread-affinity change was made. This does not rule out the Windows-3.10 failure. Keep this Draft unmerged. Next: read terminal native results, investigate/reproduce the Windows-3.10 failure, and obtain a different-instance full review at the final head. No workflows, dependencies or versions have been changed by this integration, and no tests have been disabled. |
|
Terminal author-QA results at unchanged head 8b289f9 (not an independent approval):
The integration therefore remains Draft and merge-HOLD. The next investigation must reproduce/classify that Windows-3.10 crash before claiming complete native acceptance; an independent different-session review is also required. The original #3/#5 branches and current main remain unchanged. |
This integrates the independent source fixes from #3 and #5 on current main 60ac993, which already contains merged #6's exclusion of the demonstrated Qt 6.12.0 binding regression. The older PR heads predate that dependency correction and still have failing native checks.
Validation: all three new regression cases fail against current main before integration and all 15 focused scanner/Minimap/ProjectView tests pass after integration. Native Windows Python 3.12.10, PySide6/shiboken6 6.11.1; Ruff and diff checks pass. The full local suite was still running at PR creation, with stack samples showing progress through theme application in successive tests; no full local-suite success is claimed here. Exact-head complete native CI is required before merge.
Head: 8b289f9. Integration author: Codex / GPT-6, session 01a160ec-8a99-7c83-b6e9-01276265c6a8. This Draft needs full independent review by a different instance/session; the integration author will not self-approve or self-merge. Select this corrected integration route or the original PRs, not both. Original author branches remain unchanged. No release or runtime mirror update.