Repository navigation
perf(plugin-utils): remember package resolutions and module code in the resolver - #901
Merged
Merged
Conversation
…he resolver The extractor asks the resolver again for every file that imports a module, so a shared token file or package was found and read once per importer. Package resolutions are kept per importing directory until the manifest or the entry changes, and module code until the file's stamp changes. Misses are not kept, so a package installed later is still found. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createModuleResolvernow remembers package resolutions per importing directory. An entry stays until the package manifest's stamp changes or the entry file disappears.onPackageManifestis still reported on every hit.The extractor's resolver state is per file, so before this a shared module (tokens, a barrel, a package) was found and read again for every importer.
Test plan
bun test src/import-graph.test.ts --coverage: import-graph.ts at 100% lines and functions🤖 Generated with Claude Code