Repository navigation
fix(eslint-plugin): lint @emotion/css like the build - #903
Merged
Merged
Conversation
The build aliases `@emotion/css` by default and rejects a dynamic value in its `css`, but the lint rules did not know the package, so the editor stayed silent until the build failed. Its `css`, `keyframes` and `injectGlobal` now read as Devup UI's `css`, `keyframes` and `globalCss`, as the extractor maps them. Refs #684 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@emotion/cssby default (DEFAULT_IMPORT_ALIASES) and turns a dynamic value into a build error. The eslint plugin didn't recognize the package, so no lint diagnostic appeared.ImportStoragenow recognizes@emotion/css.cssandkeyframeskeep their names, andinjectGlobalmaps toglobalCss(as the extractor'sdevup_equivalentdoes).cx,mergeand the like take class names, so they are not bound.@emotion/css'scssandinjectGlobalare now invalid, and static values pluscx(...)stay valid.Refs #684 (TOOL-03/04: the
@emotion/cssgap)Test plan
bun test packages/eslint-plugin --coverage: 100%. The one failing test is environmental (the local WASM pkg isn't built).🤖 Generated with Claude Code