[catatsumuri]

Summary

In local development, a guest opening /log/following is sent to /login. Local sign-in redirects back to the previous page, which can be /log/following, repeating the redirects until the browser reports a loop.

Send local guests directly to the home page and flash the existing sign-in modal instead.

Changes

• Handle guest Following visits locally in LogController; GitHub sign-in routing outside local development keeps its existing behavior.
• Add a regression test with Following as the referring page, checking the home redirect, sign-in modal flash, and successful home response.

Validation

• php artisan test --compact tests/Feature/Controllers/LocalSessionControllerTest.php tests/Feature/Controllers/LogControllerTest.php: 89 passed, 778 assertions, in Sail.
• vendor/bin/pint --test app/Http/Controllers/LogController.php tests/Feature/Controllers/LocalSessionControllerTest.php: passed.
• Local HTTP check: following /log/following redirects reaches / with HTTP 200 after one redirect.
• git diff --check: passed.

Independent review

No independent review performed.

Limitations

The full test suite was not run. The local HTTP check verifies the redirect chain; the modal's browser rendering was not checked.

Summary by CodeRabbit

• Improved Sign-In Experience
  • In the local environment, signed-out visitors who open the Following log are redirected to the home page with a sign-in prompt.

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

When a signed-out guest requests the Following log in the local environment, the controller flashes localSignIn and redirects to the home route. The feature test checks the redirect and confirms that the home page responds successfully.

Changes: Local Following redirect

Layer / File(s)	Summary
Local redirect and test app/Http/Controllers/LogController.php, tests/Feature/Controllers/LocalSessionControllerTest.php	In the local environment, a guest requesting Following is redirected home with localSignIn flashed. The test verifies the redirect and a successful home-page response.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Possibly related PRs

• dev-null-sh/dev-null.sh#755: Changes guest handling for the Following log in the same controller branch.

Suggested reviewers: mnapoli, nunomaduro

Merge Risk: Minimal · up to b2caa

The redirect-loop fix is supported by the routing and frontend contracts and is ready to merge.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: preventing the local sign-in redirect loop for the Following log.
Docstring Coverage		Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 2 files.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 38a80a46-ea08-4573-a650-0ef08b89cfaa

Commits

Reviewing files that changed from the base of the PR and between f2423d6 and b2caa03.

Files selected for processing: 2

• app/Http/Controllers/LogController.php
• tests/Feature/Controllers/LocalSessionControllerTest.php

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.