docs(security): correct the C-0013 gate rationale to the measured position - #3481
Conversation
…ition The rationale block for the cluster-wide C-0013 exception stated that five flux-system controllers fail the control on a missing runAsGroup. Five of the six workloads now set the field genuinely — flux-operator at 65532 via its own HelmRelease, and helm-/kustomize-/notification-/source-controller at 65534 via the FluxInstance part-of=flux selector. Read from the live Deployment specs 2026-08-30. The sole remaining gap is tofu-controller, which has no runAsGroup at container or pod level. It is a retired workload whose HelmRelease can never reconcile again and which is already absent from this repository, so the gate clears when #3480 removes it rather than by patching it. Repoints the block and the spec.reason accordingly. Also records that workloadconfigurationscans no longer discriminates here: all six now report status: passed with subStatus "w/exceptions" and a populated appliedIgnoreRules, including the one that is genuinely broken, so the obvious re-check says the gate is clearable when it is not. fixPath is likewise not a discriminator — it is a static rule hint populated identically on all six. Comment and rationale text only; no change to suppressed controls or behaviour. Part of #3223
The committed mirror is generated from the exception source; correcting the C-0013 rationale left it stale, which TestCommittedMirrorIsUpToDate caught. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
First review request at this head. @coderabbitai review |
|
✅ Action performedReview finished.
|
User evaluation at
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (1)
🧰 Additional context used📓 Path-based instructions (1)Never run a cluster📄 CodeRabbit inference engine (AGENTS.md) Files:
🧠 Learnings (1)📚 Learning: 2026-08-11T12:41:28.242ZApplied to files:
🔇 Additional comments (3)
📝 WalkthroughWalkthroughThe exception documentation now identifies Merge Risk: ⚪ Minimal · up to This change only corrects security-exception rationale and tracking text without changing controls or policy behavior; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Why
The rationale block gating the cluster-wide C-0013 exception is now wrong, and wrong in the direction that costs work. It says five Flux controllers fail the control on a missing
runAsGroup— but five of the sixflux-systemworkloads have since been fixed and pass genuinely. Anyone picking this up today re-derives that from scratch, and the block points them at the wrong tracking issue for the one workload that is still failing.It also hides a trap. The scan surface this gate was measured on used to report results before exceptions were applied; it no longer does. Every one of the six now reports
passed— including the one that is genuinely broken — so the obvious way to check whether this gate can be lifted says "yes" when the answer is "no".What
Rewrites the C-0013 rationale to state the current position: which five workloads set the field and at what uid, that the sole remaining gap is the retired
tofu-controller, and that the gate clears when #3480 removes it rather than by patching a controller on its way out. Adds an explicit warning that the scan surface fails open here, naming the field that actually discriminates and the one that looks like it does but doesn't.Comment and rationale text only — no change to which controls are suppressed or to any policy behaviour.
Part of #3223