Repository navigation
Conversation
Contributor
|
thanks for the contribution! ill get this merged soon. we're also working to revamp share so you can view them in browser so stay tuned for that :) |
Agent-Session: e05d0ee1-ebec-4824-922f-319222ec3817 Agent-Session: e8809ee0-b788-4f9d-a2e1-0cc7df5810e0 Agent-Session: d378b298-4d50-49a2-8569-c9143af1de5f Agent-Session: 3b69532b-b299-4476-8f76-f025671a4a44 Agent-Session: 23dfa6c6-9dcd-4b6d-a1f1-92c1a9513386 Agent-Session: 5375f3cc-3ab7-4c80-a744-51c661db9638 Agent-Session: 470db778-c191-40f3-98a1-b4d661e0aff9
sidkmenon
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a saved review contains metadata the portable share validator cannot read,
ShareClient.createfails before contacting the hosted service. The publishing host currently replaces that exception with “Sharing failed. Check your connection and login, then retry,” sending users back through sign-in even when their credentials are valid.Classify local bundle-validation failures as
SharePreflightError, using the existing HTTP 422 handling to show a preparation error that asks the user to report the issue. The original exception remains available as an error cause; raw validation details are not exposed in the response.Related to #1289, which already includes the
origin.baseBranchschema fix. I reproduced a named-base export failing on current main and passing with that one-line schema change. This PR addresses the remaining misleading-error path for incompatible saved data.The regression test publishes a review containing unsupported origin metadata and verifies the response, zero hosted requests, no publication callback, and an unchanged saved login. Existing success, Git-verification, and expired-token tests still pass.
Validation:
pnpm lint,pnpm format, andgit diff --checkpassed.pnpm run ciwas attempted with the required Node 24.18.0 and pnpm 11.1.2. Desktop dependency bootstrap exhausted local disk space before the full suite could run. Generated Code OSS dependencies were removed, then the publishing tests and backend typecheck passed again.