馃Ч Refactor to_geojson parameters into a dataclass - #45
Conversation
To improve code health (fixing PLR0913 "too many parameters"), the optional geographic arguments (`lat_col`, `lon_col`, `geocode_col`, `properties`) in `to_geojson` were encapsulated into a new `GeoOptions` dataclass. Full backwards compatibility was preserved by explicitly extracting legacy positional or keyword arguments into the new `options` parameter.
|
馃憢 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 馃憖 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This change resolves the "Too many parameters" code health issue in
pysus/api/export/geojson.py. The optional parameters were grouped into a@dataclassGeoOptions. Backwards compatibility for callers passing these properties positionally or as keywords has been preserved. Tested with the full test suite.PR created automatically by Jules for task 2182172615971939002 started by @devdudumuniz