Skip to content

chore: standardize release workflows #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mkuznyetsov wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: standardize release workflows #506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 35 additions & 11 deletions .github/workflows/typescript-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,10 @@
#

# Main workflow for building and publishing release builds
# Release commit
# Release commit
name: Publish project to npmjs
run-name: >-
${{ github.event_name == 'workflow_dispatch' && format('Release {0} on {1}', github.event.inputs.release-version, github.ref_name) || format('Build next for {0} @ {1}', github.ref_name, github.sha) }}

on:
workflow_dispatch:
Expand Down Expand Up @@ -40,13 +42,16 @@ jobs:
- name: Validate parameters and build type
shell: bash
id: dist-tag-eval
env:
EVENT_NAME: ${{ github.event_name }}
RELEASE_VERSION: ${{ github.event.inputs.release-version }}
REF_NAME: ${{ github.ref_name }}
run: |
# check if workflow is triggered manually (release) or via branch push (next build)
# release will always be performed as workflow_dispatch trigger, while push triggers are for dev/next builds
# based on this information, we determine the dist-tag for pushing to npmjs
DIST_TAG=
if [[ "$GITHUB_EVENT_NAME" == "workflow_dispatch" ]]; then
RELEASE_VERSION=${{ github.event.inputs.release-version }}
if [[ "$EVENT_NAME" == "workflow_dispatch" ]]; then
if [[ "$RELEASE_VERSION" =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
echo "[INFO]" preparing to build and release with version: $RELEASE_VERSION
# DIST_TAG is not used in make-release.sh, as release version will always be latest anyway
Expand All @@ -56,10 +61,10 @@ jobs:
exit 1
fi
fi
if [[ "$GITHUB_EVENT_NAME" == "push" ]]; then
if [[ ${GITHUB_REF##*/} == "7."**".x" ]]; then
echo "[INFO] using ${GITHUB_REF##*/} tag"
DIST_TAG="next-${GITHUB_REF##*/}"
if [[ "$EVENT_NAME" == "push" ]]; then
if [[ ${REF_NAME} == "7."*".x" ]]; then
echo "[INFO] using ${REF_NAME} tag"
DIST_TAG="next-${REF_NAME}"
else
echo "[INFO] using "next" tag"
DIST_TAG=next
Expand All @@ -70,14 +75,30 @@ jobs:
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Display release parameters
if: github.event_name == 'workflow_dispatch'
env:
VERSION: ${{ github.event.inputs.release-version }}
RECREATE_TAGS: ${{ github.event.inputs.release-remake }}
REF_NAME: ${{ github.ref_name }}
COMMIT_SHA: ${{ github.sha }}
TRIGGERED_BY: ${{ github.actor }}
run: |
echo "=== Release Parameters ==="
echo "Version: ${VERSION}"
echo "Recreate tags: ${RECREATE_TAGS}"
echo "Branch: ${REF_NAME}"
echo "Commit SHA: ${COMMIT_SHA}"
echo "Triggered by: ${TRIGGERED_BY}"
echo "=========================="
- name: Check existing release tags
if: github.event_name == 'workflow_dispatch'
env:
GITHUB_TOKEN: ${{secrets.DEVWORKSPACE_GENERATOR_RELEASE_GITHUB_TOKEN}}
RECREATE_TAGS: ${{ github.event.inputs.release-remake }}
VERSION: ${{ github.event.inputs.release-version }}
run: |
set +e
RECREATE_TAGS=${{ github.event.inputs.release-remake }}
VERSION=${{ github.event.inputs.release-version }}
EXISTING_TAG=$(git ls-remote --exit-code origin refs/tags/${VERSION})
if [[ -n ${EXISTING_TAG} ]]; then
if [[ ${RECREATE_TAGS} == "true" ]]; then
Expand Down Expand Up @@ -114,13 +135,16 @@ jobs:
if: github.event_name == 'workflow_dispatch'
env:
GITHUB_TOKEN: ${{secrets.DEVWORKSPACE_GENERATOR_RELEASE_GITHUB_TOKEN}}
RELEASE_VERSION: ${{ github.event.inputs.release-version }}
run: |
git config --global user.name "Mykhailo Kuznietsov"
git config --global user.email "mkuznets@redhat.com"

./make-release.sh --version ${{ github.event.inputs.release-version }}
./make-release.sh --version ${RELEASE_VERSION}
- name: Build and publish next version
if: github.event_name == 'push'
env:
NPM_DIST_TAG: ${{ steps.dist-tag-eval.outputs.npm_dist_tag }}
run: |
SHORT_SHA1=$(git rev-parse --short=7 HEAD)
CURRENT_VERSION=$(jq -r '.version' package.json)
Expand All @@ -132,4 +156,4 @@ jobs:
yarn
yarn compile

npm publish --tag ${{ steps.dist-tag-eval.outputs.npm_dist_tag }}
npm publish --tag ${NPM_DIST_TAG}
4 changes: 2 additions & 2 deletions make-release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ updatePackageVersionAndCommitChanges() {
updateXBranch() {
checkoutToXBranch

COMMIT_MSG="ci: bump ${VERSION} in ${X_BRANCH}"
COMMIT_MSG="chore(release): bump ${VERSION} in ${X_BRANCH}"

updatePackageVersionAndCommitChanges \
"${VERSION}" \
Expand All @@ -125,7 +125,7 @@ updateXBranch() {
updateMainBrain() {
checkoutToNextBranch

COMMIT_MSG="ci: bump ${NEXT_VERSION} in main"
COMMIT_MSG="chore(release): bump ${NEXT_VERSION} in main"

updatePackageVersionAndCommitChanges \
"${NEXT_VERSION}" \
Expand Down
Loading