Repository navigation
fix: repair placeholder-only answers instead of completing them - #224
atlas-coding-agent wants to merge 2 commits into
Conversation
|
@kiro-agent is attempting to deploy a commit to the devhims' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Review verdict: changes needed for head The narrow ellipsis repair is appropriate for session
Verification: independently executed the new regex classification on ellipsis, bare ranges, literal aliases, Spanish text and numeric answers, and inspected the alias/render and repair paths. This was a focused logic probe, not a full local application test. Exact-head CI Platform checks passed typechecking but failed unit tests: 3 failed, 2139 passed, 59 skipped. No live dashboard retest was run. Vercel's separate author-authorization failure is infrastructure/access, not evidence of a code defect. Keep this draft until the findings are fixed and the latest head's required checks are validated. |
|
Re-review of head Code review: no remaining material findings in this change. Overall verdict: changes needed / validation blocked, not yet approved for merge, solely pending clarification or resolution of the failed Vercel gate described below. No further code change is requested by this review. Both P2 findings from the previous head are resolved:
Verification: inspected the full PR and follow-up diff, existing citation protections, and repair flow. Exact-head Verify #577 completed successfully across all eight jobs, including both Dashboard E2E shards, Auth E2E, Platform integration, Web, documentation, library, and Platform checks. Platform logs report 2153 unit tests passed and 59 skipped; the relevant structured-answer (171), citation-range (33), and unified-finalizer (111) test files all passed, and typechecking passed. These are independently inspected CI results, not a claim that I ran the full suite locally. No live dashboard retest was performed, and saved historical answers are not backfilled. Remaining validation blocker: Vercel reports failure for this exact head because the PR author needs team authorization. This is an access/deployment gate, not a code/test failure. The connector does not establish whether this check is required by branch policy, so I am withholding merge-ready approval until the repository owner confirms it is non-required or resolves it. I have not authorized a deployment or changed repository settings. Scope remains the placeholder-only completion issue from session |
Problem / Motivation
A Spanish session finished as Completed / Answered and charged 2 credits. The answer contained only "…" followed by citation chips, and reloading the page showed the same thing.
c36be06c-9388-4eaf-bbea-c6004d7115d4f60dc202-9320-490b-bc2f-a372f031dd35, Oct 23 2026, 18:33 to 18:39 ISTExpected: a real answer, or an honest failure. Actual: a placeholder saved as a successful answer.
Diagnosis on
3d11c12(upstream main)fillerOnlyAnsweris the only content check before commit. It matches only an English fragment ("The") or an English promise ("I'll look up…"). A block of"…"with declaredevidenceIdspasses the schema's/\S/check and the filler check.renderStructuredAnswerthen appends the declared citations. The citation gate inbuildAgentTurnResultsees resolvable citations and accepts the answer.What changed
A block now counts as filler when its rendered prose has no letter or digit in any script, after the renderer's own
[cite:…]markers are removed. The check runs the same alias, range, code, link and literal handling that rendering uses. A supported range likeref_1 through ref_2therefore counts as citations only. Inline code, quoted literals, URLs and unsupported ranges count as visible text.Filler answers keep their existing contract: one repair, then the existing failure "could not pass the answer validation checks after repair". The research path keeps its existing evidence fallback. One real block is still enough.
Tests
youtube-agent-structured-answer.test.tscovers placeholders such as…, citation-only text, zero-width text and range-only text likeref_1 through ref_2andref_1 to ref_2. It also covers text that must still pass: inline coderef_1, quoted"(ref_1)", indented code, links, URLs, an unsupported range, and short Spanish, numeric and CJK answers.youtube-agent-unified-finalizer.test.ts, a Spanish run with a cited…gets repaired and commits the real answer. A repeated placeholder fails without callingfinalize.48bf915: Platform checks ran 2153 tests, 2153 passed, 59 skipped, 0 failed. All 8 workflow jobs passed. The previous headce99ac1failed 3 existing literal-context tests, and this head fixes them without changing any existing assertion.Verification limits
The sandbox's npm registry returned 403 for every package, so I could not run vitest or
tsclocally. CI is the only full test run. Vercel reports "Authorization required to deploy", which is an access issue. I did not test against the live dashboard. The PR does not change completed runs that are already saved.Separate issue, not changed here: the output-limit plus repair-timeout failure in run
2ad29797-b041-4748-b1e1-54fa99a65ebehas a different cause. Its missing receipt overlaps #183.