Repository navigation
Sort generated imports and stunt type names with ordinal comparison - #316
Merged
Merged
Conversation
Culture-sensitive sorting made generated usings and stunt names depend on the host culture, and could disagree with the run-time StuntNaming, which already sorts ordinally. Co-authored-by: CodeAlta <noreply@codealta.io> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated usings and stunt type names were sorted with the default, culture-sensitive comparer. So the output depended on the host culture (for example
lt-LTortr-TR), and builds were not reproducible across machines.The generator could also compute a different stunt name than the run-time
StuntNaming, which already sorts interfaces withStringComparer.Ordinal.This change passes
StringComparer.Ordinalto the four sorts:FixupImports: usingsNamingConvention: interfaces in the stunt nameSymbolExtensions.ValidateGeneratorTypes/TryValidateGeneratorTypes: additional interfacesAll 357 unit tests pass, with no snapshot or name changes.
This pull request was created by CodeAlta, an AI coding agent.