Repository navigation
Conversation
✅ Deploy Preview for devsydev canceled.
|
✅ Deploy Preview for images-devsy-sh canceled.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds hermetic unit tests for the logic in
pkg/ide/jetbrains/generic.go. Test-only: product code is unchanged. The other ten files in the package are constructors and option tables, so they are not covered here.Why
generic.goholds the download-URL precedence (VERSION,DOWNLOAD_AMD64,DOWNLOAD_ARM64), the install-path layout, archive extraction (strip level and path-traversal rejection), arch-specific download, and the no-plugins early return. None of these had tests.Validation
go test -race -count=3 ./pkg/ide/jetbrains/...: pass.mise run cli:format: no changes.mise run cli:lint:ci: 0 issues.generic.gobyte-identical afterwards):extract.StripLevels(1)toStripLevels(0):TestExtractArchiveStripsTopLevelDirectoryfails.RemoteDevpath segment:TestGetDirectoryUnderHomefails.t.TempDir,httptest, and in-memory tar.gz archives. No network or real$HOME.CodeRabbit CLI
coderabbit review --agent --committedon194801c: completed, 0 findings.Auto-merge
Not eligible for auto-merge until a human marks it ready.
Next
GetVolumeandgetDownloadFolderbuild container paths withfilepath.Join. On Windows that yields backslashes in the mountdst. Asserting the literal would fail on Windows, and fixing it is a product change.installPluginswith plugins: needsCredential(root) to run.Install/OpenGateway: need the real user home and network.VERSIONdefaults tolatest, which makesDOWNLOAD_*overrides ignored. Not pinned by a test; needs a product decision.