Repository navigation
Conversation
✅ Deploy Preview for devsydev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for images-devsy-sh canceled.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@greptileai review Please review the current head |
[Low impact] Test fixtures for provider dependency contracts. The PR appears safe to merge, with two non-blocking improvements to the test-owned validators. FindingsSummaryAdds test-owned provider dependency reports, a JSON schema, contract validators, and a source ledger.
Acknowledged scope from Reviews (1) · Last reviewed commit: "test(dependencies): add provider depende..." · Reviewed by Greptile |
Summary
Adds Provider Dependencies foundations and the first functional passive command:
devsy dependency inspect <tool> --for-provider <installed-name> --jsonfor trusted built-in Docker, Podman, Apple and Kubernetes providers.Why
Provider inspection needs a useful CLI entry point whose startup and error paths preserve passive behavior. Shared observations, wire output and durable metadata establish the foundation for later explicit dependency actions and Desktop integration; installation and managed support are not enabled here.
Validation
Full serial validation on VPS1 passed on unchanged tree
878d11464aaf677852dafbbc5b5f0e51dd49c74b:mise exec -- prek run --all-files: passed, including format, secrets and Go lint hooks.go test -p 1 -race -count=1 -v ./cmd ./cmd/dependency ./cmd/flags: passed, including all 36 actual-main PTY inspection cases, strict fresh-root preservation and ordinary proxy/process positive controls.mise run cli:lint:ci: passed, 0 issues. Native/Linux complete-feature patch lint passed; separate unfiltered scoped lint retains 42 findings in unchanged lines.Signed coherent formatter/cache/command commits preserve the validated tree. Current head:
0609cee23bc5a0a7afb1ecf7925c3e0885ad6629. Fresh GitHub CI and final reviewers remain pending.Spec refs/task/test IDs
Tracks #1575. T00a/T00b, T02, T03 paths/codecs/private writer/read-only resolution, T04 lookup/internal Survey/built-in translation/loaders/static saved-preview preparation; T10 root lifecycle/report/functional inspect. SPEC sections 6.3-6.5/7/8.5/11, C18/C20 and REVIEW_ADDENDUM sections 2/3/5/6/7. Guard-map evidence distinguishes implemented tests from future unwired seams.
Gates affected
G01-G09 NOT RUN; managed recipes/ranges disabled. No installer, selection, removal, adapter release or Desktop flow is enabled. Native Windows and managed runtime/hardware qualification remain absent; Windows metadata writes are unsupported. Fault injection is not power-loss evidence. Metadata writers provide no CAS/multi-file transaction or ownership/removal authority. Snapshot digests are neither file identity nor atomic snapshots/CAS. Constructor BindEnv fatal errors, profile-tag initialization, completion and synchronous filesystem/driver limits remain outside the passive guarantee. Sentinel/proxy fixtures provide bounded evidence, not OS-wide interception.
Next
Fresh exact-head CI, completed Greptile >= 4/5, then completed CodeRabbit and all actionable threads resolved before readiness. External-provider trust, saved selection/store reconciliation, bounded probes, secure installation/ownership, remaining CLI and Desktop work accumulate here. User approval is required before merge; qualification gates remain separate.