Skip to content

test(command): avoid fork race in SIGTERM fixture #1608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skevetter merged 1 commit into from
Oct 21, 2026
Merged

test(command): avoid fork race in SIGTERM fixture #1608

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion pkg/command/process_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,13 @@ func startSigtermIgnoringGroup(t *testing.T) *exec.Cmd {
t.Helper()
ready := filepath.Join(t.TempDir(), "ready")
// #nosec G204 -- the fixed shell script and all paths are test-controlled.
cmd := exec.Command("sh", "-c", `trap '' TERM; printf 'ready\n' > "$1"; sleep 30`, "sh", ready)
cmd := exec.Command(
"sh",
"-c",
`trap '' TERM; printf 'ready\n' > "$1"; exec sleep 30`,
"sh",
ready,
)
cmd.SysProcAttr = &syscall.SysProcAttr{Setpgid: true}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Resolved
if err := cmd.Start(); err != nil {
t.Fatalf("start SIGTERM-ignoring group: %v", err)
Expand Down
Loading