Skip to content

fix(bundle): hold a bundle to regular files and directories #868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raymondk wants to merge 6 commits into from
+621 −24
Open

fix(bundle): hold a bundle to regular files and directories #868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f7623c8
fix(bundle): hold a bundle to regular files and directories
raymondk Nov 4, 2026
3290a83
fix(bundle): refuse the output, a non-UTF-8 name and a looping link b…
raymondk Nov 4, 2026
ac2fee4
docs(bundle): keep the Intel macOS chore out of Experimental, drop a …
raymondk Nov 5, 2026
6c698af
refactor(bundle): resolve each directory once on the walk, and list n…
raymondk Nov 10, 2026
2e91364
fix(bundle): resolve the output once it exists, for the walk to refuse
raymondk Nov 10, 2026
8cbd12e
fix(bundle): hold a files: entry to what the walk holds, and resolve …
raymondk Nov 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ air-gapped signing, extensions

* chore: macOS on Intel (`x86_64-apple-darwin`) is no longer a release target. Releases ship no Intel macOS archive, the shell installer refuses that platform, and npm no longer publishes `@icp-sdk/icp-cli-darwin-x64`, so installing `@icp-sdk/icp-cli` on an Intel Mac warns of an unsupported platform. Homebrew dropped Intel macOS in September 2026, and GitHub is retiring its Intel macOS runners. v1.8.0 is the last release with an Intel macOS build.

## Experimental
Comment thread
lwshang marked this conversation as resolved.
Resolved

* fix(bundle): `icp project bundle` holds only regular files and directories. A symlink inside a plugin's `files:` or `dirs:` directory used to be recorded as a link with its target unchecked, so one pointing outside the project reached that file on whatever machine unpacked the bundle. A link to somewhere inside the project is now copied as what it points at; one that leads outside the project, dangles, or leads back to a directory being copied fails the bundle, naming the link and where it leads. The same holds for a `files:` entry that is itself a symlink.

# v1.8.0

* fix: `icp sync` no longer needs controller rights. Its check that each canister is running used `canister_status`, which only a controller or a listed status viewer may read, so an identity the canister merely authorizes (a developer preparing an SNS-owned frontend for a commit proposal, say) was refused before anything was uploaded. It now probes with a query, as `icp deploy` already does after starting a canister. A stopped canister is still refused with the same advice, after the probe's 30-second wait rather than at once.
Expand Down
Loading
Loading