Repository navigation
test: match the no-Wasm-module error case-insensitively - #870
Merged
Merged
Conversation
Network launcher 16.1.0-2026-10-30-12-16 capitalizes "Wasm" in the rejection for calling a canister with no code, which broke the case-sensitive assertion in canister_uninstall. Accept both spellings so this can land ahead of the launcher bump in #864. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the test assertion update accepting both wasm and Wasm in the no-module error.
No open issues 🎉
What changed in this PR
Updates the canister uninstall test to accept both wasm and Wasm in the no-module error, unblocking the launcher upgrade in #864 while preserving compatibility with the current launcher.
Changes:
- Imports the
is_matchpredicate. - Replaces the case-sensitive substring assertion with a case-insensitive regular expression.
| File | Description |
|---|---|
crates/icp-cli/tests/canister_uninstall_tests.rs |
Makes the no-Wasm-module error assertion case-insensitive. |
Review effort: Balanced
lwshang
enabled auto-merge (squash)
November 5, 2026 07:32
raymondk
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks #864 (launcher bump to
16.1.0-2026-10-30-12-16), which failscanister_uninstallon every platform.The new launcher capitalizes the rejection text for calling a canister with no code:
...but the canister contains no wasm module....but the canister contains no Wasm module..The assertion used a case-sensitive
contains("no wasm module"). It now usesis_match("(?i)no wasm module"), so it passes on both launcher versions and can merge before #864. The bot PR can't touch test files, so this has to be a separate PR.Verified locally:
cargo test -p icp-cli --test canister_uninstall_testspasses on the current launcher (this branch) and on the new one (#864's branch).🤖 Generated with Claude Code