Repository navigation
Improve template accessibility and responsive layouts - #10
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 7 7
=========================================
Hits 7 7 ☔ View full report in Codecov by Harness. |
Coverage Report for CI Build 39943614197Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage remained the same at 100.0%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 912a44f002
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| footer { | ||
| width: auto; |
There was a problem hiding this comment.
At viewport widths from 576px through 767.98px, the pkgdown layout nests the footer inside .container, while Bootstrap caps that container at 540px. Overriding the existing 100vw breakout with width: auto therefore limits the footer background to 540px—for example, leaving roughly 113px of uncovered space on each side at 767px—even though it becomes full-width again at 768px. The reported 320px and 390px checks do not exercise this interval; retain a viewport-wide background breakout here while addressing overflow.
Useful? React with 👍 / 👎.
dieghernan
added
bug
dieghernan
changed the title
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e8efcc0d5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # gitdevr 0.0.0.9000 | ||
|
|
||
| - Inline links remain identifiable without color, keyboard focus is visible and diffviewer text is readable in both modes. Footer backgrounds now span the viewport between the small and medium breakpoints without horizontal overflow (#10). | ||
| - Mobile navigation, sidebars, footers and copy buttons now follow the shared responsive layout. Tab and pill hover styles no longer affect other navigation components, and development badges use the shared red color. |
There was a problem hiding this comment.
This new user-facing bullet does not identify its related issue, making the changelog entry inconsistent with the repository's required NEWS format; append the appropriate issue number in parentheses.
AGENTS.md reference: AGENTS.md:L117-L117
Useful? React with 👍 / 👎.
| } | ||
|
|
||
| /* Keep the title, version, and menu toggle on one row on narrow phones. */ | ||
| @media (max-width: 375px) { |
There was a problem hiding this comment.
This introduces breakpoint-specific navbar behavior without adding a corresponding test; the existing stylesheet tests only check broad selector presence and source/minified equivalence, so the max-width: 375px sizing rule could disappear or change unnoticed. Add a focused assertion or rendering fixture for this responsive behavior.
AGENTS.md reference: AGENTS.md:L91-L91
Useful? React with 👍 / 👎.
Align responsive code spacing and copy buttons with the shared template behavior, scope tab/pill hover styles and keep narrow navigation controls on one row.
Keep inline content and footer links underlined, provide visible keyboard focus and improve diffviewer text contrast in both color modes. Preserve the GitDev light/dark palettes and typography.
Address the review finding about intermediate-width footers: the background now paints across the viewport without expanding the footer layout box or causing horizontal overflow. Verified visually and sampled the rendered background at both outer edges at 640 and 767 px in both modes.
Validation:
104 related test assertions pass.