Repository navigation
Organize CSS and align GitDev skin colors - #9
Merged
Merged
Conversation
dieghernan
added
ai-assisted 🤖
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 7 7
=========================================
Hits 7 7 ☔ View full report in Codecov by Harness. |
Coverage Report for CI Build 39501602793Coverage remained the same at 100.0%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
dieghernan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Organize gitdevr's existing stylesheet into nine indexed component sections and consolidate equivalent callout, Reactable filter/search, and button parameter rules. Keep gitdevr's theme tokens, component behavior, footer layout, and syntax highlighting.
The second commit aligns the remaining palette differences with Chulapa's
gitdevandgitdev-darkskins:#0d1117.#8b949efor navbar/dropdown hover states, retaining this readable shade on the light site's dark navbar too.#24292fand primary#373e47, avoiding the ambiguousdarkalias.Only existing files are modified. No scripts, screenshots, dependencies, or new source files are added. The first commit is a rendering-preserving reorganization; the second contains the intentional skin-color corrections above. The footer's layout implementation remains unchanged.
Validation:
devtools::lint(),jarl check ., formatting and whitespace checks passed.#22272enavbar /#0d1117footer in light mode, and#24292fbody/navbar/footer in dark mode. Navbar hover resolves to#8b949ein both modes.References: https://github.com/dieghernan/chulapa/blob/main/_sass/skins/gitdev.scss and https://github.com/dieghernan/chulapa/blob/main/_sass/skins/gitdev-dark.scss.