Repository navigation
hotfix(ai): prevent ChatGPT compaction cache-option errors - #302
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix ChatGPT auto-compaction and
/compactfailures caused by HTTP 400prompt_cache_options is not supported on this model.ChatGPT catalog discovery inherits API-key model capabilities. Summarization sets
cacheRetention: "none", which turns the inherited explicit-cache capability intoprompt_cache_options: { "mode": "explicit" }. The reported ChatGPT subscription request rejects that parameter.Reasoning
Explicit-cache support must be scoped to the subscription route rather than inherited from API-key pricing metadata.
Normalize both freshly fetched and restored ChatGPT catalogs so existing installations recover without deleting cached models, including offline startup and failed catalog refreshes. Keep the shared OpenAI adapter and API-key caching behavior unchanged.
Changes
supportsExplicitPromptCacheModewhen constructing or restoring ChatGPT model catalogs; preserve other model capabilities.Testing
npm run check— passed, including TypeScript and browser smoke checks.packages/ai:node ../../node_modules/vitest/dist/cli.js --run test/chatgpt-inference.test.ts test/cache-retention.test.ts test/providers.test.ts— 56 passed, 4 skipped.git diff --check— passed../test.sh— blocked in the script-test phase: 428 passed, 3 packaging tests failed withENOENTfor missing prebuiltpackages/ai/distin the isolated worktree. Workspace suites were not reached. No build was run.