Skip to content

build: remove deprecation usage of wxpython to make build successfully - #304

Open
stevenhua0320 wants to merge 1 commit into
diffpy:mainfrom
stevenhua0320:fix-deprecation-usage
Open

build: remove deprecation usage of wxpython to make build successfully#304
stevenhua0320 wants to merge 1 commit into
diffpy:mainfrom
stevenhua0320:fix-deprecation-usage

Conversation

@stevenhua0320

Copy link
Copy Markdown
Contributor

Closes #303 @sbillinge ready to review. In this PR:
We removed the deprecative usage of wxpython and the default size for the gui button is 16 by 16, so we could safely comment the lines affected right now.

@codecov

codecov Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.10%. Comparing base (9496a69) to head (c446790).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #304   +/-   ##
=======================================
  Coverage   95.10%   95.10%           
=======================================
  Files          23       23           
  Lines        1123     1123           
=======================================
  Hits         1068     1068           
  Misses         55       55           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stevenhua0320

Copy link
Copy Markdown
Contributor Author

@sbillinge This fails the pre-commit hook, but it still wires with the old hooks. I saw there is a PR ongoing about the pre-commit update #302, so it might be good to first close that one by @stevengeorge128 and then revist once the hook is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bitmap.SetSize() is deprecated in wxpython 4.0+, wxpython<4 no longer available through PyPI or Conda-Forge

1 participant